Re: [PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-09-15 Thread Pratyush Anand
On Thu, Sep 15, 2016 at 9:48 PM, Will Deacon wrote: > On Thu, Sep 15, 2016 at 09:45:09PM +0530, Pratyush Anand wrote: >> On Wed, Aug 24, 2016 at 3:36 PM, Pratyush Anand wrote: >> > On 23/08/2016:04:33:08 PM, Sandeepa Prabhu wrote: >> >> Thanks for the fix, feel free to add my ACK as well. Has it

Re: [PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-09-15 Thread Will Deacon
On Thu, Sep 15, 2016 at 09:45:09PM +0530, Pratyush Anand wrote: > On Wed, Aug 24, 2016 at 3:36 PM, Pratyush Anand wrote: > > On 23/08/2016:04:33:08 PM, Sandeepa Prabhu wrote: > >> Thanks for the fix, feel free to add my ACK as well. Has it been tested on > >> guest kernel? > > > > have not tested

Re: [PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-09-15 Thread Pratyush Anand
Hi Sandeepa, On Wed, Aug 24, 2016 at 3:36 PM, Pratyush Anand wrote: > Hi Sandeepa, > > Thanks for the review. > > On 23/08/2016:04:33:08 PM, Sandeepa Prabhu wrote: >> Thanks for the fix, feel free to add my ACK as well. Has it been tested on >> guest kernel? > > have not tested on guest kernel.W

Re: [PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-08-24 Thread Pratyush Anand
Hi Sandeepa, Thanks for the review. On 23/08/2016:04:33:08 PM, Sandeepa Prabhu wrote: > Thanks for the fix, feel free to add my ACK as well. Has it been tested on > guest kernel? have not tested on guest kernel.Will do. ~Pratyush > > Acked-by: Sandeepa Prabhu > > > > On Mon, Aug 22, 2016

Re: [PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-08-24 Thread Pratyush Anand
Hi Sandeepa, On 24/08/2016:03:09:16 PM, Sandeepa Prabhu wrote: > On Mon, Aug 22, 2016 at 12:16 PM, Pratyush Anand wrote: > > > Whenever we are hitting a kprobe from a none-kprobe debug exception > > handler, we hit an infinite occurrences of "Unexpected kernel single-step > > exception at EL1" >

Re: [PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-08-22 Thread Masami Hiramatsu
On Mon, 22 Aug 2016 12:16:00 +0530 Pratyush Anand wrote: > Whenever we are hitting a kprobe from a none-kprobe debug exception > handler, we hit an infinite occurrences of "Unexpected kernel single-step > exception at EL1" > > PSTATE.D is debug exception mask bit. It is set whenever we enter int

[PATCH] arm64: kprobe: Always clear pstate.D in breakpoint exception handler

2016-08-21 Thread Pratyush Anand
Whenever we are hitting a kprobe from a none-kprobe debug exception handler, we hit an infinite occurrences of "Unexpected kernel single-step exception at EL1" PSTATE.D is debug exception mask bit. It is set whenever we enter into an exception mode. When it is set then Watchpoint, Breakpoint, and