Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-13 Thread Catalin Marinas
On Fri, 8 Jan 2021 10:19:56 +0100, Arnd Bergmann wrote: > With UBSAN enabled and building with clang, there are occasionally > warnings like > > WARNING: modpost: vmlinux.o(.text+0xc533ec): Section mismatch in reference > from the function arch_atomic64_or() to the variable >

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-13 Thread Will Deacon
On Tue, Jan 12, 2021 at 10:23:12AM +, Mark Rutland wrote: > On Fri, Jan 08, 2021 at 09:39:53PM +0100, Peter Zijlstra wrote: > > On Fri, Jan 08, 2021 at 09:32:58AM +, Will Deacon wrote: > > > Hi Arnd, > > > > > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > > > From:

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-12 Thread Mark Rutland
On Fri, Jan 08, 2021 at 09:39:53PM +0100, Peter Zijlstra wrote: > On Fri, Jan 08, 2021 at 09:32:58AM +, Will Deacon wrote: > > Hi Arnd, > > > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > With UBSAN enabled and building with clang,

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Nick Desaulniers
On Fri, Jan 8, 2021 at 2:27 AM Arnd Bergmann wrote: > > On Fri, Jan 8, 2021 at 10:33 AM Will Deacon wrote: > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > With UBSAN enabled and building with clang, there are occasionally > > > warnings

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Peter Zijlstra
On Fri, Jan 08, 2021 at 09:32:58AM +, Will Deacon wrote: > Hi Arnd, > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > With UBSAN enabled and building with clang, there are occasionally > > warnings like > > > > WARNING: modpost:

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Arnd Bergmann
On Fri, Jan 8, 2021 at 7:50 PM Will Deacon wrote: > On Fri, Jan 08, 2021 at 11:26:53AM +0100, Arnd Bergmann wrote: > > > > a) fully inline it as the __always_inline attribute does > > b) not inline it at all, treating it as a regular static function > > c) create a specialized version with

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Will Deacon
On Fri, Jan 08, 2021 at 11:26:53AM +0100, Arnd Bergmann wrote: > On Fri, Jan 8, 2021 at 10:33 AM Will Deacon wrote: > > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > With UBSAN enabled and building with clang, there are occasionally > > >

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Arnd Bergmann
On Fri, Jan 8, 2021 at 10:33 AM Will Deacon wrote: > On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > With UBSAN enabled and building with clang, there are occasionally > > warnings like > > > > WARNING: modpost: vmlinux.o(.text+0xc533ec): Section

Re: [PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Will Deacon
Hi Arnd, On Fri, Jan 08, 2021 at 10:19:56AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > With UBSAN enabled and building with clang, there are occasionally > warnings like > > WARNING: modpost: vmlinux.o(.text+0xc533ec): Section mismatch in reference > from the function

[PATCH] arm64: make atomic helpers __always_inline

2021-01-08 Thread Arnd Bergmann
From: Arnd Bergmann With UBSAN enabled and building with clang, there are occasionally warnings like WARNING: modpost: vmlinux.o(.text+0xc533ec): Section mismatch in reference from the function arch_atomic64_or() to the variable .init.data:numa_nodes_parsed The function arch_atomic64_or()