Re: [PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-15 Thread Robert Richter
On 15.12.16 11:01:04, Yisheng Xie wrote: > > I sent a V2 patch that uses pfn_present(). This only initilizes > > sections with memory. > hmm， maybe I do not quite catch what your mean, but I do not think > pfn_present is right for this case. > > IMO, The valid_section() means the section with mem_

Re: [PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-14 Thread Yisheng Xie
hi Robert, On 2016/12/14 17:45, Robert Richter wrote: > On 12.12.16 17:53:02, Yisheng Xie wrote: >> It seems that memblock_is_memory() is also too strict for early_pfn_valid, >> so what about this patch, which use common pfn_valid as early_pfn_valid >> when CONFIG_HAVE_ARCH_PFN_VALID=y: >> ---

Re: [PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-14 Thread Robert Richter
On 12.12.16 17:53:02, Yisheng Xie wrote: > It seems that memblock_is_memory() is also too strict for early_pfn_valid, > so what about this patch, which use common pfn_valid as early_pfn_valid > when CONFIG_HAVE_ARCH_PFN_VALID=y: > > diff --git a/include/linux/mmzone.h b/include/linux/m

Re: [PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-12 Thread Yisheng Xie
hi Robert, On 2016/12/12 11:12, Yisheng Xie wrote: > hi Robert, > > On 2016/12/10 2:10, Robert Richter wrote: >> On ThunderX systems with certain memory configurations we see the >> following BUG_ON(): >> >> kernel BUG at mm/page_alloc.c:1848! >> >> This happens for some configs with 64k page si

Re: [PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-11 Thread Yisheng Xie
hi Robert, On 2016/12/10 2:10, Robert Richter wrote: > On ThunderX systems with certain memory configurations we see the > following BUG_ON(): > > kernel BUG at mm/page_alloc.c:1848! > > This happens for some configs with 64k page size enabled. The BUG_ON() > checks if start and end page of a m

Re: [PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-09 Thread Russell King - ARM Linux
On Fri, Dec 09, 2016 at 07:10:41PM +0100, Robert Richter wrote: > On ThunderX systems with certain memory configurations we see the > following BUG_ON(): > > kernel BUG at mm/page_alloc.c:1848! > > This happens for some configs with 64k page size enabled. The BUG_ON() > checks if start and end p

[PATCH] arm64: mm: Fix NOMAP page initialization

2016-12-09 Thread Robert Richter
On ThunderX systems with certain memory configurations we see the following BUG_ON(): kernel BUG at mm/page_alloc.c:1848! This happens for some configs with 64k page size enabled. The BUG_ON() checks if start and end page of a memmap range belongs to the same zone. The BUG_ON() check fails if a