Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Ard Biesheuvel
On Mon, 22 Mar 2021 at 16:57, Ard Biesheuvel wrote: > > On Mon, 22 Mar 2021 at 14:26, Will Deacon wrote: > > > > On Fri, 19 Mar 2021 18:41:06 +, Mark Rutland wrote: > > > We recently converted arm64 to use arch_stack_walk() in commit: > > > > > > 5fc57df2f6fd ("arm64: stacktrace: Convert

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Ard Biesheuvel
On Mon, 22 Mar 2021 at 14:26, Will Deacon wrote: > > On Fri, 19 Mar 2021 18:41:06 +, Mark Rutland wrote: > > We recently converted arm64 to use arch_stack_walk() in commit: > > > > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") > > > > The core stacktrace code expects that

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Will Deacon
On Fri, 19 Mar 2021 18:41:06 +, Mark Rutland wrote: > We recently converted arm64 to use arch_stack_walk() in commit: > > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") > > The core stacktrace code expects that (when tracing the current task) > arch_stack_walk() starts a

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Mark Rutland
On Fri, Mar 19, 2021 at 07:02:06PM +, Catalin Marinas wrote: > On Fri, Mar 19, 2021 at 06:41:06PM +, Mark Rutland wrote: > > We recently converted arm64 to use arch_stack_walk() in commit: > > > > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") > > > > The core stacktrace

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Mark Brown
On Fri, Mar 19, 2021 at 06:41:06PM +, Mark Rutland wrote: > We recently converted arm64 to use arch_stack_walk() in commit: > > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") > > The core stacktrace code expects that (when tracing the current task) > arch_stack_walk() starts

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-19 Thread Catalin Marinas
On Fri, Mar 19, 2021 at 06:41:06PM +, Mark Rutland wrote: > We recently converted arm64 to use arch_stack_walk() in commit: > > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") > > The core stacktrace code expects that (when tracing the current task) > arch_stack_walk() starts

[PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-19 Thread Mark Rutland
We recently converted arm64 to use arch_stack_walk() in commit: 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") The core stacktrace code expects that (when tracing the current task) arch_stack_walk() starts a trace at its caller, and does not include itself in the trace. However,