Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-30 Thread Anders Roxell
On Tue, 30 Jul 2019 at 14:43, Will Deacon wrote: > > On Tue, Jul 30, 2019 at 02:30:27PM +0200, Anders Roxell wrote: > > On Tue, 30 Jul 2019 at 13:28, Will Deacon wrote: > > > > > > On Tue, Jul 30, 2019 at 12:24:15PM +0100, Mark Rutland wrote: > > > > On Fri, Jul 26, 2019 at 04:18:25PM +0100, Lore

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-30 Thread Will Deacon
On Tue, Jul 30, 2019 at 02:30:27PM +0200, Anders Roxell wrote: > On Tue, 30 Jul 2019 at 13:28, Will Deacon wrote: > > > > On Tue, Jul 30, 2019 at 12:24:15PM +0100, Mark Rutland wrote: > > > On Fri, Jul 26, 2019 at 04:18:25PM +0100, Lorenzo Pieralisi wrote: > > > > On Fri, Jul 26, 2019 at 01:29:56P

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-30 Thread Anders Roxell
On Tue, 30 Jul 2019 at 13:28, Will Deacon wrote: > > On Tue, Jul 30, 2019 at 12:24:15PM +0100, Mark Rutland wrote: > > On Fri, Jul 26, 2019 at 04:18:25PM +0100, Lorenzo Pieralisi wrote: > > > On Fri, Jul 26, 2019 at 01:29:56PM +0100, Mark Rutland wrote: > > > > On Fri, Jul 26, 2019 at 01:27:37PM +

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-30 Thread Mark Rutland
On Tue, Jul 30, 2019 at 12:27:59PM +0100, Will Deacon wrote: > On Tue, Jul 30, 2019 at 12:24:15PM +0100, Mark Rutland wrote: > > On Fri, Jul 26, 2019 at 04:18:25PM +0100, Lorenzo Pieralisi wrote: > > > On Fri, Jul 26, 2019 at 01:29:56PM +0100, Mark Rutland wrote: > > > > On Fri, Jul 26, 2019 at 01:

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-30 Thread Will Deacon
On Tue, Jul 30, 2019 at 12:24:15PM +0100, Mark Rutland wrote: > On Fri, Jul 26, 2019 at 04:18:25PM +0100, Lorenzo Pieralisi wrote: > > On Fri, Jul 26, 2019 at 01:29:56PM +0100, Mark Rutland wrote: > > > On Fri, Jul 26, 2019 at 01:27:37PM +0200, Anders Roxell wrote: > > > > When fall-through warning

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-30 Thread Mark Rutland
On Fri, Jul 26, 2019 at 04:18:25PM +0100, Lorenzo Pieralisi wrote: > On Fri, Jul 26, 2019 at 01:29:56PM +0100, Mark Rutland wrote: > > On Fri, Jul 26, 2019 at 01:27:37PM +0200, Anders Roxell wrote: > > > When fall-through warnings was enabled by default the following warning > > > was starting to s

[PATCH] arm_pmu: mark expected switch fall-through

2019-07-28 Thread Matteo Croce
Mark switch cases where we are expecting to fall through, fixes the following warning: drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’: drivers/perf/arm_pmu.c:726:3: warning: this statement may fall through [-Wimplicit-fallthrough=] cpu_pm_pmu_setup(armpmu, cmd); ^~~

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-26 Thread Lorenzo Pieralisi
On Fri, Jul 26, 2019 at 01:29:56PM +0100, Mark Rutland wrote: > On Fri, Jul 26, 2019 at 01:27:37PM +0200, Anders Roxell wrote: > > When fall-through warnings was enabled by default the following warning > > was starting to show up: > > > > ../drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-26 Thread Will Deacon
On Fri, Jul 26, 2019 at 01:29:56PM +0100, Mark Rutland wrote: > On Fri, Jul 26, 2019 at 01:27:37PM +0200, Anders Roxell wrote: > > When fall-through warnings was enabled by default the following warning > > was starting to show up: > > > > ../drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’

Re: [PATCH] arm_pmu: Mark expected switch fall-through

2019-07-26 Thread Mark Rutland
On Fri, Jul 26, 2019 at 01:27:37PM +0200, Anders Roxell wrote: > When fall-through warnings was enabled by default the following warning > was starting to show up: > > ../drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’: > ../drivers/perf/arm_pmu.c:726:3: warning: this statement may fall >

[PATCH] arm_pmu: Mark expected switch fall-through

2019-07-26 Thread Anders Roxell
When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’: ../drivers/perf/arm_pmu.c:726:3: warning: this statement may fall through [-Wimplicit-fallthrough=] cpu_pm_pmu_setup(armpmu, cmd); ^~~