Re: [PATCH] asm/io: Correct output operand specification of the MMIO write* routines

2019-04-18 Thread Michael Matz
Hi, On Wed, 17 Apr 2019, Linus Torvalds wrote: > So I see no upside to changing it. As long as the memory clobber stays (and it can't be removed in the general case, as you say) the change has no practical effect. It does have a psychological upside, though: people won't continue to wonder w

Re: [PATCH] asm/io: Correct output operand specification of the MMIO write* routines

2019-04-17 Thread Linus Torvalds
On Wed, Apr 17, 2019 at 1:50 AM Borislav Petkov wrote: > > I'm looking at > > c1f64a58003f ("x86: MMIO and gcc re-ordering issue") > > and trying to figure out was there any particular reason the address to > the MMIO write routines had to be an input operand? It doesn't have to be an input ope

[PATCH] asm/io: Correct output operand specification of the MMIO write* routines

2019-04-17 Thread Borislav Petkov
Hi Linus, I'm looking at c1f64a58003f ("x86: MMIO and gcc re-ordering issue") and trying to figure out was there any particular reason the address to the MMIO write routines had to be an input operand? Because if not, please have a look at the patch below. It boots here and from the couple of