Re: [PATCH] asm-generic: fix ffs -Wshadow warning

2020-10-26 Thread Arnd Bergmann
On Mon, Oct 26, 2020 at 5:44 PM David Laight wrote: > > An alternative would be to add #define ffs(x) our_inline_ffs(x) > before the inline function definition. Yes, that would also work. > I though the idea of the __builtin_ prefix was that you could > have a function with the same name :-( It

RE: [PATCH] asm-generic: fix ffs -Wshadow warning

2020-10-26 Thread David Laight
From: Arnd Bergmann > Sent: 26 October 2020 16:00 > > From: Arnd Bergmann > > gcc -Wshadow warns about the ffs() definition that has the > same name as the global ffs() built-in: > > include/asm-generic/bitops/builtin-ffs.h:13:28: warning: declaration of 'ffs' > shadows a built-in > function [

[PATCH] asm-generic: fix ffs -Wshadow warning

2020-10-26 Thread Arnd Bergmann
From: Arnd Bergmann gcc -Wshadow warns about the ffs() definition that has the same name as the global ffs() built-in: include/asm-generic/bitops/builtin-ffs.h:13:28: warning: declaration of 'ffs' shadows a built-in function [-Wshadow] This is annoying because 'make W=2' warns every time this