Re: [PATCH] at24: make module parameters changeable via sysfs

2012-12-18 Thread Jean Delvare
On Tue, 18 Dec 2012 12:59:26 +0100, Wolfram Sang wrote: > > > I reviewed this patch 3 months ago and did not hear back. Are you going > > to update this patch and resubmit, or should I just drop it? > > Uwe is on holiday. I'll take care about it if the need is still there... The need was Uwe's o

Re: [PATCH] at24: make module parameters changeable via sysfs

2012-12-18 Thread Wolfram Sang
> I reviewed this patch 3 months ago and did not hear back. Are you going > to update this patch and resubmit, or should I just drop it? Uwe is on holiday. I'll take care about it if the need is still there... -- Pengutronix e.K. | Wolfram Sang| Industr

Re: [PATCH] at24: make module parameters changeable via sysfs

2012-12-18 Thread Jean Delvare
Uwe, On Fri, 14 Sep 2012 10:25:36 +0200, Jean Delvare wrote: > On Wed, 12 Sep 2012 11:43:32 +0200, Uwe Kleine-König wrote: > > The respective values are evaluated at each read/write, so no further > > action is required than to change the perm argument to module_param. > > > > Note there is no sa

Re: [PATCH] at24: make module parameters changeable via sysfs

2012-09-14 Thread Jean Delvare
Hi Uwe, On Wed, 12 Sep 2012 11:43:32 +0200, Uwe Kleine-König wrote: > The respective values are evaluated at each read/write, so no further > action is required than to change the perm argument to module_param. > > Note there is no sanity check so root can make the driver effectively > unusable b

[PATCH] at24: make module parameters changeable via sysfs

2012-09-12 Thread Uwe Kleine-König
The respective values are evaluated at each read/write, so no further action is required than to change the perm argument to module_param. Note there is no sanity check so root can make the driver effectively unusable but that's what root is for :-) Signed-off-by: Uwe Kleine-König --- drivers/m