Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-20 Thread Stephen Douthit
On 8/19/19 10:17 PM, Dan Williams wrote: > On Mon, Aug 19, 2019 at 9:30 AM Stephen Douthit > wrote: >> >> On 8/14/19 1:17 PM, Dan Williams wrote: Can you get someone from the controller design team to give us a clear answer on a revision where this PCS change happened? It

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-19 Thread Dan Williams
On Mon, Aug 19, 2019 at 9:30 AM Stephen Douthit wrote: > > On 8/14/19 1:17 PM, Dan Williams wrote: > >> Can you get someone from the controller design team to give us a clear > >> answer on a revision where this PCS change happened? > >> > >> It would be nice if we could just check

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-19 Thread Stephen Douthit
On 8/14/19 1:17 PM, Dan Williams wrote: >> Can you get someone from the controller design team to give us a clear >> answer on a revision where this PCS change happened? >> >> It would be nice if we could just check PCI_REVISION_ID or something >> similar. > > I don't think such a reliable

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-14 Thread Dan Williams
On Wed, Aug 14, 2019 at 9:54 AM Stephen Douthit wrote: > > On 8/14/19 12:09 PM, Dan Williams wrote: > > On Wed, Aug 14, 2019 at 7:34 AM Stephen Douthit > > wrote: > >> > >> On 8/13/19 6:07 PM, Dan Williams wrote: > >>> On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig > >>> wrote: > >

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-14 Thread Stephen Douthit
On 8/14/19 12:09 PM, Dan Williams wrote: > On Wed, Aug 14, 2019 at 7:34 AM Stephen Douthit > wrote: >> >> On 8/13/19 6:07 PM, Dan Williams wrote: >>> On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig >>> wrote: On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: > It

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-14 Thread Dan Williams
On Wed, Aug 14, 2019 at 7:34 AM Stephen Douthit wrote: > > On 8/13/19 6:07 PM, Dan Williams wrote: > > On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig > > wrote: > >> > >> On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: > >>> It seems platforms / controllers that fail to run

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-14 Thread Stephen Douthit
On 8/13/19 6:07 PM, Dan Williams wrote: > On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig wrote: >> >> On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: >>> It seems platforms / controllers that fail to run the option-rom >>> should be quirked by device-id, but the PCS register

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-13 Thread Dan Williams
On Tue, Aug 13, 2019 at 12:31 AM Christoph Hellwig wrote: > > On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: > > It seems platforms / controllers that fail to run the option-rom > > should be quirked by device-id, but the PCS register twiddling be > > removed for everyone else.

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-13 Thread Christoph Hellwig
On Mon, Aug 12, 2019 at 12:31:35PM -0700, Dan Williams wrote: > It seems platforms / controllers that fail to run the option-rom > should be quirked by device-id, but the PCS register twiddling be > removed for everyone else. "Card BIOS" to me implies devices with an > Option-ROM BAR which I don't

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Dan Williams
On Mon, Aug 12, 2019 at 11:08 AM Christoph Hellwig wrote: > > On Mon, Aug 12, 2019 at 05:49:29PM +, Stephen Douthit wrote: > > Does anyone know the background of the original PCS workaround? > > Based on a few git-blame iterations on history.git the original PCS > handling (just when

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Stephen Douthit
On 8/12/19 2:06 PM, Christoph Hellwig wrote: > On Mon, Aug 12, 2019 at 05:49:29PM +, Stephen Douthit wrote: >> Does anyone know the background of the original PCS workaround? > > Based on a few git-blame iterations on history.git the original PCS > handling (just when initializing) goes back

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Christoph Hellwig
On Mon, Aug 12, 2019 at 05:49:29PM +, Stephen Douthit wrote: > Does anyone know the background of the original PCS workaround? Based on a few git-blame iterations on history.git the original PCS handling (just when initializing) goes back to this BK commit: -- >From

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Stephen Douthit
On 8/12/19 12:29 PM, Dan Williams wrote: > On Mon, Aug 12, 2019 at 6:03 AM Stephen Douthit > wrote: >> >> On 8/10/19 3:43 AM, Christoph Hellwig wrote: >>> On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: Intel moved the PCS register from 0x92 to 0x94 on Denverton for some

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Dan Williams
On Mon, Aug 12, 2019 at 6:03 AM Stephen Douthit wrote: > > On 8/10/19 3:43 AM, Christoph Hellwig wrote: > > On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: > >> Intel moved the PCS register from 0x92 to 0x94 on Denverton for some > >> reason, so now we get to check the device ID

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Jens Axboe
On 8/12/19 6:02 AM, Stephen Douthit wrote: > On 8/10/19 3:43 AM, Christoph Hellwig wrote: >> On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: >>> Intel moved the PCS register from 0x92 to 0x94 on Denverton for some >>> reason, so now we get to check the device ID before poking it

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-12 Thread Stephen Douthit
On 8/10/19 3:43 AM, Christoph Hellwig wrote: > On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: >> Intel moved the PCS register from 0x92 to 0x94 on Denverton for some >> reason, so now we get to check the device ID before poking it on reset. > > And now you just match on the new

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-10 Thread Dan Williams
On Sat, Aug 10, 2019 at 12:43 AM Christoph Hellwig wrote: > > On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: > > Intel moved the PCS register from 0x92 to 0x94 on Denverton for some > > reason, so now we get to check the device ID before poking it on reset. > > And now you just

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-10 Thread Christoph Hellwig
On Thu, Aug 08, 2019 at 08:24:31PM +, Stephen Douthit wrote: > Intel moved the PCS register from 0x92 to 0x94 on Denverton for some > reason, so now we get to check the device ID before poking it on reset. And now you just match on the new IDs, which means we'll perpetually catch up on any

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-09 Thread Jens Axboe
On 8/9/19 7:13 AM, Stephen Douthit wrote: > On 8/8/19 11:46 PM, Jens Axboe wrote: >> On 8/8/19 1:24 PM, Stephen Douthit wrote: >>> Intel moved the PCS register from 0x92 to 0x94 on Denverton for some >>> reason, so now we get to check the device ID before poking it on reset. >>> >>> Signed-off-by:

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-09 Thread Stephen Douthit
On 8/8/19 11:46 PM, Jens Axboe wrote: > On 8/8/19 1:24 PM, Stephen Douthit wrote: >> Intel moved the PCS register from 0x92 to 0x94 on Denverton for some >> reason, so now we get to check the device ID before poking it on reset. >> >> Signed-off-by: Stephen Douthit >> --- >>drivers/ata/ahci.c

Re: [PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-08 Thread Jens Axboe
On 8/8/19 1:24 PM, Stephen Douthit wrote: > Intel moved the PCS register from 0x92 to 0x94 on Denverton for some > reason, so now we get to check the device ID before poking it on reset. > > Signed-off-by: Stephen Douthit > --- > drivers/ata/ahci.c | 42

[PATCH] ata: ahci: Lookup PCS register offset based on PCI device ID

2019-08-08 Thread Stephen Douthit
Intel moved the PCS register from 0x92 to 0x94 on Denverton for some reason, so now we get to check the device ID before poking it on reset. Signed-off-by: Stephen Douthit --- drivers/ata/ahci.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-)