Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-20 Thread Peter Griffin
Hi Tejun, On Fri, 17 Apr 2015, Tejun Heo wrote: > On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote: > > Yes I can test, although not until Saturday as I only have remote > > access to the board today & tomorrow and the hard drive isn't > > plugged in. > > What's the status on this

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-20 Thread Peter Griffin
Hi Tejun, On Fri, 17 Apr 2015, Tejun Heo wrote: On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote: Yes I can test, although not until Saturday as I only have remote access to the board today tomorrow and the hard drive isn't plugged in. What's the status on this patch?

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-17 Thread Tejun Heo
On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote: > Yes I can test, although not until Saturday as I only have remote > access to the board today & tomorrow and the hard drive isn't > plugged in. What's the status on this patch? Should I push it through for-4.1-fixes? Thanks. --

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-17 Thread Tejun Heo
On Thu, Apr 09, 2015 at 10:43:10AM +0100, Peter Griffin wrote: Yes I can test, although not until Saturday as I only have remote access to the board today tomorrow and the hard drive isn't plugged in. What's the status on this patch? Should I push it through for-4.1-fixes? Thanks. --

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Brian Norris
On Thu, Apr 09, 2015 at 12:34:02PM +0300, Sergei Shtylyov wrote: > Hello. > > On 4/8/2015 9:59 PM, Brian Norris wrote: > > >When working on another SATA driver that uses libahci_platform, I > >noticed an error in this driver; it tries to the the driver data for its > >device, while libata also

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Peter Griffin
Hi Maxime, On Thu, 09 Apr 2015, Maxime Coquelin wrote: > Hello Brian, > > > drivers/ata/ahci_st.c | 25 ++--- > > 1 file changed, 14 insertions(+), 11 deletions(-) > > > > > > Your patch looks sensible, thanks for spotting this issue. > > Peter, do you have the SATA setup

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Sergei Shtylyov
Hello. On 4/8/2015 9:59 PM, Brian Norris wrote: When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() ->

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Maxime Coquelin
Hello Brian, On 04/08/2015 08:59 PM, Brian Norris wrote: When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host()

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Brian Norris
On Thu, Apr 09, 2015 at 12:34:02PM +0300, Sergei Shtylyov wrote: Hello. On 4/8/2015 9:59 PM, Brian Norris wrote: When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Sergei Shtylyov
Hello. On 4/8/2015 9:59 PM, Brian Norris wrote: When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() -

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Maxime Coquelin
Hello Brian, On 04/08/2015 08:59 PM, Brian Norris wrote: When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host()

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Peter Griffin
Hi Maxime, On Thu, 09 Apr 2015, Maxime Coquelin wrote: Hello Brian, snip drivers/ata/ahci_st.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) Your patch looks sensible, thanks for spotting this issue. Peter, do you have the SATA setup in place

[PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-08 Thread Brian Norris
When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() -> ata_host_alloc_pinfo() -> ata_host_alloc() ->

[PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-08 Thread Brian Norris
When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() - ata_host_alloc_pinfo() - ata_host_alloc() -