Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Jeff Garzik
On 12/14/2012 06:01 AM, Konstantin Khlebnikov wrote: This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was mentioned recently in debug patch

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Borislav Petkov
On Fri, Dec 14, 2012 at 03:45:49PM +0400, Konstantin Khlebnikov wrote: > ouch :facepalm: how I missed this... just copy-paste error. sorry again. No sorries - it can happen to anyone! :-) Keep up the good work. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk.

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Konstantin Khlebnikov
Borislav Petkov wrote: On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote: This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Alan Cox
On Fri, 14 Dec 2012 15:01:37 +0400 Konstantin Khlebnikov wrote: > This patch uncomments ata timings for XFER_PIO_SLOW, > otherwise ata_timing_find_mode() returns NULL and kernel crashes in > pacpi_set_dmamode() after null-pointer dereference. NAK please see the previous discussion of this and

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Borislav Petkov
On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote: > This patch uncomments ata timings for XFER_PIO_SLOW, > otherwise ata_timing_find_mode() returns NULL and kernel crashes in > pacpi_set_dmamode() after null-pointer dereference. > > The same problem was mentioned recently in

[PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Konstantin Khlebnikov
This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was mentioned recently in debug patch v3.7-rc5-72-gcd705d5 ("libata debugging: Warn when unable to find

[PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Konstantin Khlebnikov
This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was mentioned recently in debug patch v3.7-rc5-72-gcd705d5 (libata debugging: Warn when unable to find

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Borislav Petkov
On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote: This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was mentioned recently in debug

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Alan Cox
On Fri, 14 Dec 2012 15:01:37 +0400 Konstantin Khlebnikov khlebni...@openvz.org wrote: This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. NAK please see the previous

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Konstantin Khlebnikov
Borislav Petkov wrote: On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote: This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Borislav Petkov
On Fri, Dec 14, 2012 at 03:45:49PM +0400, Konstantin Khlebnikov wrote: ouch :facepalm: how I missed this... just copy-paste error. sorry again. No sorries - it can happen to anyone! :-) Keep up the good work. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk.

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Jeff Garzik
On 12/14/2012 06:01 AM, Konstantin Khlebnikov wrote: This patch uncomments ata timings for XFER_PIO_SLOW, otherwise ata_timing_find_mode() returns NULL and kernel crashes in pacpi_set_dmamode() after null-pointer dereference. The same problem was mentioned recently in debug patch