Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-14 Thread Catalin Marinas
On 13/12/06, Catalin Marinas <[EMAIL PROTECTED]> wrote: On 11/12/06, Tejun Heo <[EMAIL PROTECTED]> wrote: > piix_init_one() allocates host private data which should be freed by > piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() > while merging, leaking 4 bytes on driver

Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-14 Thread Catalin Marinas
On 13/12/06, Catalin Marinas [EMAIL PROTECTED] wrote: On 11/12/06, Tejun Heo [EMAIL PROTECTED] wrote: piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix

Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-13 Thread Catalin Marinas
Tejun, On 11/12/06, Tejun Heo <[EMAIL PROTECTED]> wrote: piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix it. I tried your patch last night but the

Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-13 Thread Catalin Marinas
Tejun, On 11/12/06, Tejun Heo [EMAIL PROTECTED] wrote: piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix it. I tried your patch last night but the leak

Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-11 Thread Alan
On Mon, 11 Dec 2006 22:26:25 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > piix_init_one() allocates host private data which should be freed by > piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() > while merging, leaking 4 bytes on driver detach. Fix it. > > This was spotted

[PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-11 Thread Tejun Heo
piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix it. This was spotted using Kmemleak by Catalin Marinas. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc:

[PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-11 Thread Tejun Heo
piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix it. This was spotted using Kmemleak by Catalin Marinas. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc:

Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

2006-12-11 Thread Alan
On Mon, 11 Dec 2006 22:26:25 +0900 Tejun Heo [EMAIL PROTECTED] wrote: piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix it. This was spotted using