Re: [PATCH] atm/svc: Fix blocking in wait loop

2014-08-12 Thread David Miller
From: chas williams - CONTRACTOR Date: Tue, 12 Aug 2014 08:12:26 -0400 > One should not call blocking primitives inside a wait loop, since both > require task_struct::state to sleep, so the inner will destroy the > outer state. > > sigd_enq() will possibly sleep for alloc_skb(). Move

[PATCH] atm/svc: Fix blocking in wait loop

2014-08-12 Thread chas williams - CONTRACTOR
One should not call blocking primitives inside a wait loop, since both require task_struct::state to sleep, so the inner will destroy the outer state. sigd_enq() will possibly sleep for alloc_skb(). Move sigd_enq() before prepare_to_wait() to avoid sleeping while waiting interruptibly. You do

[PATCH] atm/svc: Fix blocking in wait loop

2014-08-12 Thread chas williams - CONTRACTOR
One should not call blocking primitives inside a wait loop, since both require task_struct::state to sleep, so the inner will destroy the outer state. sigd_enq() will possibly sleep for alloc_skb(). Move sigd_enq() before prepare_to_wait() to avoid sleeping while waiting interruptibly. You do

Re: [PATCH] atm/svc: Fix blocking in wait loop

2014-08-12 Thread David Miller
From: chas williams - CONTRACTOR c...@cmf.nrl.navy.mil Date: Tue, 12 Aug 2014 08:12:26 -0400 One should not call blocking primitives inside a wait loop, since both require task_struct::state to sleep, so the inner will destroy the outer state. sigd_enq() will possibly sleep for alloc_skb().