Re: [PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-30 Thread David Brownell
I think I'll sign off on this as-is. On Wednesday 16 May 2007, Håvard Skinnemoen wrote: > On 5/16/07, David Brownell <[EMAIL PROTECTED]> wrote: > > It's legit to set up cpu-virtual (for PIO) and dma addresses > > for each buffer, since the upper layer driver has no way to > > know if the

Re: [PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-30 Thread David Brownell
I think I'll sign off on this as-is. On Wednesday 16 May 2007, Håvard Skinnemoen wrote: On 5/16/07, David Brownell [EMAIL PROTECTED] wrote: It's legit to set up cpu-virtual (for PIO) and dma addresses for each buffer, since the upper layer driver has no way to know if the underlying

Re: [PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-16 Thread Håvard Skinnemoen
On 5/16/07, David Brownell <[EMAIL PROTECTED]> wrote: On Wednesday 16 May 2007, Haavard Skinnemoen wrote: > - tx_dma = xfer->tx_dma; > - rx_dma = xfer->rx_dma; > + tx_dma = xfer->tx_dma + xfer->len - len; > + rx_dma = xfer->rx_dma + xfer->len - len; > > /* use scratch

Re: [PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-16 Thread David Brownell
On Wednesday 16 May 2007, Haavard Skinnemoen wrote: > When either rx_buf or tx_buf is not being used, i.e. for plain read- > or write operations, the atmel_spi uses a fixed-size DMA buffer > instead. If the transfer is longer than the size of this buffer, it is > split into multiple DMA transfers.

[PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-16 Thread Haavard Skinnemoen
When either rx_buf or tx_buf is not being used, i.e. for plain read- or write operations, the atmel_spi uses a fixed-size DMA buffer instead. If the transfer is longer than the size of this buffer, it is split into multiple DMA transfers. When the transfer is split like this, the atmel_spi driver

[PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-16 Thread Haavard Skinnemoen
When either rx_buf or tx_buf is not being used, i.e. for plain read- or write operations, the atmel_spi uses a fixed-size DMA buffer instead. If the transfer is longer than the size of this buffer, it is split into multiple DMA transfers. When the transfer is split like this, the atmel_spi driver

Re: [PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-16 Thread David Brownell
On Wednesday 16 May 2007, Haavard Skinnemoen wrote: When either rx_buf or tx_buf is not being used, i.e. for plain read- or write operations, the atmel_spi uses a fixed-size DMA buffer instead. If the transfer is longer than the size of this buffer, it is split into multiple DMA transfers.

Re: [PATCH] atmel_spi: Pass correct DMA address to controller

2007-05-16 Thread Håvard Skinnemoen
On 5/16/07, David Brownell [EMAIL PROTECTED] wrote: On Wednesday 16 May 2007, Haavard Skinnemoen wrote: - tx_dma = xfer-tx_dma; - rx_dma = xfer-rx_dma; + tx_dma = xfer-tx_dma + xfer-len - len; + rx_dma = xfer-rx_dma + xfer-len - len; /* use scratch buffer only when rx