Re: [PATCH] audit: remove the audit freelist

On Thu, Dec 1, 2016 at 7:09 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: >> > Paul Moore wrote: >> >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal

Re: [PATCH] audit: remove the audit freelist

On Thu, Dec 1, 2016 at 7:09 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: >> > Paul Moore wrote: >> >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: >> >> > allows better debugging as freeing audit buffers now always

Re: [PATCH] audit: remove the audit freelist

Paul Moore wrote: > On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: > > Paul Moore wrote: > >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > >> > allows better debugging as freeing audit buffers now

Re: [PATCH] audit: remove the audit freelist

Paul Moore wrote: > On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: > > Paul Moore wrote: > >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > >> > allows better debugging as freeing audit buffers now always honors slub > >> > debug hooks (e.g. object poisoning) and leak

Re: [PATCH] audit: remove the audit freelist

On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: >> > allows better debugging as freeing audit buffers now always honors slub >> > debug hooks (e.g.

Re: [PATCH] audit: remove the audit freelist

On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: >> > allows better debugging as freeing audit buffers now always honors slub >> > debug hooks (e.g. object poisoning) and leak checker can detect the >> >

Re: [PATCH] audit: remove the audit freelist

Paul Moore wrote: > On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > > allows better debugging as freeing audit buffers now always honors slub > > debug hooks (e.g. object poisoning) and leak checker can detect the > > free operation. > > > >

Re: [PATCH] audit: remove the audit freelist

Paul Moore wrote: > On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > > allows better debugging as freeing audit buffers now always honors slub > > debug hooks (e.g. object poisoning) and leak checker can detect the > > free operation. > > > > Removal also results in a small speedup

Re: [PATCH] audit: remove the audit freelist

On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single

Re: [PATCH] audit: remove the audit freelist

On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A

Re: [PATCH] audit: remove the audit freelist

On 2016-11-29 18:24, Florian Westphal wrote: > Richard Guy Briggs wrote: > > > static void audit_buffer_free(struct audit_buffer *ab) > > > { > > > - unsigned long flags; > > > - > > > if (!ab) > > > return; > > > > > > kfree_skb(ab->skb); > > > -

Re: [PATCH] audit: remove the audit freelist

On 2016-11-29 18:24, Florian Westphal wrote: > Richard Guy Briggs wrote: > > > static void audit_buffer_free(struct audit_buffer *ab) > > > { > > > - unsigned long flags; > > > - > > > if (!ab) > > > return; > > > > > > kfree_skb(ab->skb); > > > -

Re: [PATCH] audit: remove the audit freelist

Richard Guy Briggs wrote: > > static void audit_buffer_free(struct audit_buffer *ab) > > { > > - unsigned long flags; > > - > > if (!ab) > > return; > > > > kfree_skb(ab->skb); > > - spin_lock_irqsave(_freelist_lock, flags); > > - if

Re: [PATCH] audit: remove the audit freelist

Richard Guy Briggs wrote: > > static void audit_buffer_free(struct audit_buffer *ab) > > { > > - unsigned long flags; > > - > > if (!ab) > > return; > > > > kfree_skb(ab->skb); > > - spin_lock_irqsave(_freelist_lock, flags); > > - if (audit_freelist_count >

Re: [PATCH] audit: remove the audit freelist

On 2016-11-15 14:16, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A INPUT -i lo

Re: [PATCH] audit: remove the audit freelist

On 2016-11-15 14:16, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A INPUT -i lo

[PATCH] audit: remove the audit freelist

allows better debugging as freeing audit buffers now always honors slub debug hooks (e.g. object poisoning) and leak checker can detect the free operation. Removal also results in a small speedup (using single rule 'iptables -A INPUT -i lo -j AUDIT --type drop'): super_netperf 4 -H 127.0.0.1 -l

[PATCH] audit: remove the audit freelist

allows better debugging as freeing audit buffers now always honors slub debug hooks (e.g. object poisoning) and leak checker can detect the free operation. Removal also results in a small speedup (using single rule 'iptables -A INPUT -i lo -j AUDIT --type drop'): super_netperf 4 -H 127.0.0.1 -l