Re: [PATCH] autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

2017-06-16 Thread Michael Ellerman
NeilBrown writes: > On Thu, Jun 15 2017, Andrew Morton wrote: >> On Wed, 07 Jun 2017 12:08:38 +1000 NeilBrown wrote: >>> --- a/fs/autofs4/dev-ioctl.c >>> +++ b/fs/autofs4/dev-ioctl.c >>> @@ -344,7 +344,7 @@ static int autofs_dev_ioctl_fail(struct file *fp, >>> int status; >>> >>> token

Re: [PATCH] autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

2017-06-15 Thread Ian Kent
On Fri, 2017-06-16 at 12:13 +1000, NeilBrown wrote: > On Thu, Jun 15 2017, Andrew Morton wrote: > > > On Wed, 07 Jun 2017 12:08:38 +1000 NeilBrown wrote: > > > > > > > > If a positive status is passed with the AUTOFS_DEV_IOCTL_FAIL > > > ioctl, autofs4_d_automount() will return > > >    ERR_PTR

Re: [PATCH] autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

2017-06-15 Thread NeilBrown
On Thu, Jun 15 2017, Andrew Morton wrote: > On Wed, 07 Jun 2017 12:08:38 +1000 NeilBrown wrote: > >> >> If a positive status is passed with the AUTOFS_DEV_IOCTL_FAIL >> ioctl, autofs4_d_automount() will return >>ERR_PTR(status) >> with that status to follow_automount(), which will then >> de

Re: [PATCH] autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

2017-06-15 Thread Andrew Morton
On Wed, 07 Jun 2017 12:08:38 +1000 NeilBrown wrote: > > If a positive status is passed with the AUTOFS_DEV_IOCTL_FAIL > ioctl, autofs4_d_automount() will return >ERR_PTR(status) > with that status to follow_automount(), which will then > dereference an invalid pointer. > > So treat a positi

[PATCH] autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

2017-06-06 Thread NeilBrown
If a positive status is passed with the AUTOFS_DEV_IOCTL_FAIL ioctl, autofs4_d_automount() will return ERR_PTR(status) with that status to follow_automount(), which will then dereference an invalid pointer. So treat a positive status the same as zero, and map to ENOENT. See comment in systemd