Re: [PATCH] autofs4: Use wait_event_killable

On Tue, Mar 20, 2018 at 09:58:59AM +0800, Ian Kent wrote: > On 20/03/18 03:16, Matthew Wilcox wrote: > > From: Matthew Wilcox > > This playing with signals to allow only fatal signals appears to predate > > the introduction of wait_event_killable(), and I'm fairly sure that > > wait_event_killable

Re: [PATCH] autofs4: Use wait_event_killable

On 20/03/18 03:25, David Rientjes wrote: > On Mon, 19 Mar 2018, Matthew Wilcox wrote: > >> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c >> index a0c57c37fa21..c160e9b3aa0f 100644 >> --- a/fs/autofs4/waitq.c >> +++ b/fs/autofs4/waitq.c >> @@ -19,9 +19,6 @@ >> */ >> static autofs_wqt_t au

Re: [PATCH] autofs4: Use wait_event_killable

On 20/03/18 03:16, Matthew Wilcox wrote: > From: Matthew Wilcox Hi Matthew, > > This playing with signals to allow only fatal signals appears to predate > the introduction of wait_event_killable(), and I'm fairly sure that > wait_event_killable is what was meant to happen here. Predates is an

Re: [PATCH] autofs4: Use wait_event_killable

On Mon, Mar 19, 2018 at 12:25:58PM -0700, David Rientjes wrote: > On Mon, 19 Mar 2018, Matthew Wilcox wrote: > > * wq->name.name is NULL iff the lock is already released > > * or the mount has been made catatonic. > > */ > > - if (wq->name.name) { > > - /* Block all but "

Re: [PATCH] autofs4: Use wait_event_killable

On Mon, 19 Mar 2018, Matthew Wilcox wrote: > diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c > index a0c57c37fa21..c160e9b3aa0f 100644 > --- a/fs/autofs4/waitq.c > +++ b/fs/autofs4/waitq.c > @@ -19,9 +19,6 @@ > */ > static autofs_wqt_t autofs4_next_wait_queue = 1; > > -/* These are the s

[PATCH] autofs4: Use wait_event_killable

From: Matthew Wilcox This playing with signals to allow only fatal signals appears to predate the introduction of wait_event_killable(), and I'm fairly sure that wait_event_killable is what was meant to happen here. Signed-off-by: Matthew Wilcox --- fs/autofs4/waitq.c | 27 +---