Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

2019-02-13 Thread Miguel Ojeda
On Mon, Feb 11, 2019 at 8:26 AM Robin van der Gracht wrote: > > Looks good > > Acked-by: Robin van der Gracht Thanks all! I will send this for -rc7. Cheers, Miguel

Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

2019-02-10 Thread Robin van der Gracht
On Sat, 9 Feb 2019 01:15:22 +0100 Miguel Ojeda wrote: > On module unload/remove, we need to ensure that work does not run > after we have freed resources. Concretely, cancel_delayed_work() > may return while the callback function is still running. > > From kernel/workqueue.c: > > The work c

Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

2019-02-10 Thread Sven Van Asbroeck
On Fri, Feb 8, 2019 at 7:15 PM Miguel Ojeda wrote: > > On module unload/remove, we need to ensure that work does not run > after we have freed resources. Concretely, cancel_delayed_work() > may return while the callback function is still running. > > From kernel/workqueue.c: > > The work callb

Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

2019-02-09 Thread Dmitry Torokhov
On Sat, Feb 09, 2019 at 01:15:22AM +0100, Miguel Ojeda wrote: > On module unload/remove, we need to ensure that work does not run > after we have freed resources. Concretely, cancel_delayed_work() > may return while the callback function is still running. > > From kernel/workqueue.c: > > The

[PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

2019-02-08 Thread Miguel Ojeda
On module unload/remove, we need to ensure that work does not run after we have freed resources. Concretely, cancel_delayed_work() may return while the callback function is still running. >From kernel/workqueue.c: The work callback function may still be running on return, unless it return