Valdis,
On Tue, 12 Mar 2019, Valdis Klētnieks wrote:
I've applied the lot, but I had to fixup the subject lines.
# git log path/to/file
gives you a decent hint on what the usual prefix and format is.
'b/arch/x86/mm/pti.c -'
is obviously not.
Thanks,
tglx
On Tue, 12 Mar 2019, Dave Hansen wrote:
> > Make both variables static.
>
> "pti_set_kernel_image_nonglobal(void)" is an awfully funny looking
> variable. ;)
>
> > Signed-off-by: Valdis Kletnieks
> >
> > ---
> > diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c
> > index 4fee5c3003ed..139b28a
> Make both variables static.
"pti_set_kernel_image_nonglobal(void)" is an awfully funny looking
variable. ;)
> Signed-off-by: Valdis Kletnieks
>
> ---
> diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c
> index 4fee5c3003ed..139b28a01ce4 100644
> --- a/arch/x86/mm/pti.c
> +++ b/arch/x86/mm/pt
With 'make C=2 W=1', sparse and gcc both complain:
CHECK arch/x86/mm/pti.c
arch/x86/mm/pti.c:84:3: warning: symbol 'pti_mode' was not declared. Should it
be static?
arch/x86/mm/pti.c:605:6: warning: symbol 'pti_set_kernel_image_nonglobal' was
not declared. Should it be static?
CC arch
4 matches
Mail list logo
