Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-10 Thread Heiko Stübner
Hi, Am Dienstag, 4. November 2014, 17:15:32 schrieb Lee Jones: > Actually there is a better way still: > > #ifdef CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > struct backlight_device *of_find_backlight_by_node(struct device_node > *node); #else > static inline struct backlight_device

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-10 Thread Heiko Stübner
Hi, Am Dienstag, 4. November 2014, 17:15:32 schrieb Lee Jones: Actually there is a better way still: #ifdef CONFIG_OF IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) struct backlight_device *of_find_backlight_by_node(struct device_node *node); #else static inline struct backlight_device *

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Lee Jones
> > > > > > > I've removed this patch, as it causes unexpected: > > > > Redefinition of of_find_backlight_by_node() > > > > > > I reproduced the same build error. > > > > > > Then, how about folding the following two pa

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Heiko Stübner
; > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > Applied to Backlight -next with Jingoo's Ack. > > > > > > I've removed this patch, as it causes unexpected: > > > Redefinition of of_find_backlight_by_node() &g

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Lee Jones
gt; > Applied to Backlight -next with Jingoo's Ack. > > > > I've removed this patch, as it causes unexpected: > > > > Redefinition of of_find_backlight_by_node() > > I reproduced the same build error. > > Then, how about folding the following two patches into &g

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Jingoo Han
by_node() I reproduced the same build error. Then, how about folding the following two patches into one single patch? These two patches were already sent by Heiko Stübner. [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled [PATCH] backlight: extend

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Lee Jones
On Mon, 03 Nov 2014, Lee Jones wrote: > On Wed, 29 Oct 2014, Heiko Stübner wrote: > > > Drivers may want to search for an optional backlight even when the backlight > > class is disabled. In this case the linker would miss the function > > referenced > > in the backlight header. > > > >

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Lee Jones
On Mon, 03 Nov 2014, Lee Jones wrote: On Wed, 29 Oct 2014, Heiko Stübner wrote: Drivers may want to search for an optional backlight even when the backlight class is disabled. In this case the linker would miss the function referenced in the backlight header. Therefore use the

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Jingoo Han
] backlight: use of_find_backlight_by_node stub when backlight class disabled [PATCH] backlight: extend of_find_backlight_by_node stub-check to modules Then, the one single patch will do as follows. -#ifdef CONFIG_OF +#if defined(CONFIG_OF) (defined(CONFIG_BACKLIGHT_CLASS_DEVICE

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Lee Jones
patch? These two patches were already sent by Heiko Stübner. [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled [PATCH] backlight: extend of_find_backlight_by_node stub-check to modules Then, the one single patch will do as follows. -#ifdef CONFIG_OF

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Heiko Stübner
. Then, how about folding the following two patches into one single patch? These two patches were already sent by Heiko Stübner. [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled [PATCH] backlight: extend of_find_backlight_by_node stub-check

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-04 Thread Lee Jones
of of_find_backlight_by_node() I reproduced the same build error. Then, how about folding the following two patches into one single patch? These two patches were already sent by Heiko Stübner. [PATCH] backlight: use of_find_backlight_by_node stub when backlight class

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-03 Thread Lee Jones
On Wed, 29 Oct 2014, Heiko Stübner wrote: > Drivers may want to search for an optional backlight even when the backlight > class is disabled. In this case the linker would miss the function referenced > in the backlight header. > > Therefore use the stub function also when the backlight class is

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-11-03 Thread Lee Jones
On Wed, 29 Oct 2014, Heiko Stübner wrote: Drivers may want to search for an optional backlight even when the backlight class is disabled. In this case the linker would miss the function referenced in the backlight header. Therefore use the stub function also when the backlight class is

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-10-29 Thread Jingoo Han
On Wednesday, October 29, 2014 9:20 AM, Heiko Stübner wrote: > > Drivers may want to search for an optional backlight even when the backlight > class is disabled. In this case the linker would miss the function referenced > in the backlight header. > > Therefore use the stub function also when

Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-10-29 Thread Jingoo Han
On Wednesday, October 29, 2014 9:20 AM, Heiko Stübner wrote: Drivers may want to search for an optional backlight even when the backlight class is disabled. In this case the linker would miss the function referenced in the backlight header. Therefore use the stub function also when the

[PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-10-28 Thread Heiko Stübner
Drivers may want to search for an optional backlight even when the backlight class is disabled. In this case the linker would miss the function referenced in the backlight header. Therefore use the stub function also when the backlight class is disabled. Signed-off-by: Heiko Stuebner ---

[PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled

2014-10-28 Thread Heiko Stübner
Drivers may want to search for an optional backlight even when the backlight class is disabled. In this case the linker would miss the function referenced in the backlight header. Therefore use the stub function also when the backlight class is disabled. Signed-off-by: Heiko Stuebner