Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-16 Thread Rafael J. Wysocki
On Thursday, July 12, 2018 11:18:26 AM CEST Benjamin Gaignard wrote: > 2018-07-12 10:55 GMT+02:00 Greg KH : > > On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote: > >> In some cases the link between between customer and supplier > >> already exist. Do not warn about already existing

Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-14 Thread Mark Brown
On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote: > In some cases the link between between customer and supplier > already exist. Do not warn about already existing dependencies > because device_link_add() take care of this case. Reviwed-by: Mark Brown signature.asc Description

Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-12 Thread Mark Brown
On Thu, Jul 12, 2018 at 11:18:26AM +0200, Benjamin Gaignard wrote: > 2018-07-12 10:55 GMT+02:00 Greg KH : > > Why would a link already exist that is asked to be created again? What > > code path causes this? > It could happen that the link exist because a device use it parent as > supplier. > T

Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-12 Thread Benjamin Gaignard
2018-07-12 10:55 GMT+02:00 Greg KH : > On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote: >> In some cases the link between between customer and supplier >> already exist. Do not warn about already existing dependencies >> because device_link_add() take care of this case. > > Why wo

Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-12 Thread Greg KH
On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote: > In some cases the link between between customer and supplier > already exist. Do not warn about already existing dependencies > because device_link_add() take care of this case. Why would a link already exist that is asked to be

[PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-12 Thread Benjamin Gaignard
In some cases the link between between customer and supplier already exist. Do not warn about already existing dependencies because device_link_add() take care of this case. Reported-by: Marek Szyprowski Signed-off-by: Benjamin Gaignard --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insert