Re: [PATCH] bcache: Remove nested function from sysfs

2017-10-06 Thread Coly Li
On 2017/10/7 上午5:35, Matthias Kaehlcke wrote: > From: Behan Webster > > Replace the use of nested functions where a normal function will > suffice. > > Nested functions are not liked by upstream kernel developers in > general. Their use breaks the use of clang as a compiler, and > doesn't make t

[PATCH] bcache: Remove nested function from sysfs

2017-10-06 Thread Matthias Kaehlcke
From: Behan Webster Replace the use of nested functions where a normal function will suffice. Nested functions are not liked by upstream kernel developers in general. Their use breaks the use of clang as a compiler, and doesn't make the code any better. This code now works for both gcc and clan