Re: [PATCH] bcache: remove unnecessary null poiner check in cache_set_free

2018-09-10 Thread zhong jiang
On 2018/9/11 8:59, Junhui Tang wrote: > This patch is NOT OK to me,maybe many cache in a cache_set, and some > cache are not registered yet, so ca is possible NULL. Yep, It's my fault. please ingnore the patch. Thanks, zhong jiang > zhong jiang 于2018年9月8日周六 下午7:52写道: >> The iterator in for_e

Re: [PATCH] bcache: remove unnecessary null poiner check in cache_set_free

2018-09-10 Thread Junhui Tang
This patch is NOT OK to me,maybe many cache in a cache_set, and some cache are not registered yet, so ca is possible NULL. zhong jiang 于2018年9月8日周六 下午7:52写道: > > The iterator in for_each_cache is never null, therefore, remove > the redundant null pointer check. > > Signed-off-by: zhong jiang > -

[PATCH] bcache: remove unnecessary null poiner check in cache_set_free

2018-09-08 Thread zhong jiang
The iterator in for_each_cache is never null, therefore, remove the redundant null pointer check. Signed-off-by: zhong jiang --- drivers/md/bcache/super.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 9