Re: [PATCH] bcm2048: Fix checkpatch checks

2017-02-27 Thread Man Choy
On Mon, Feb 27, 2017 at 4:21 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: >> Fix following checks: >> >> CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather >> than BUG() or BUG_ON() >> +

Re: [PATCH] bcm2048: Fix checkpatch checks

2017-02-27 Thread Man Choy
On Mon, Feb 27, 2017 at 4:21 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: >> Fix following checks: >> >> CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather >> than BUG() or BUG_ON() >> + BUG_ON((index+2) >=

Re: [PATCH] bcm2048: Fix checkpatch checks

2017-02-27 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: > Fix following checks: > > CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather > than BUG() or BUG_ON() > + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); > > CHECK: spaces preferred around that '+' (ctx:VxV) > +

Re: [PATCH] bcm2048: Fix checkpatch checks

2017-02-27 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: > Fix following checks: > > CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather > than BUG() or BUG_ON() > + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); > > CHECK: spaces preferred around that '+' (ctx:VxV) > +

[PATCH] bcm2048: Fix checkpatch checks

2017-02-17 Thread Man Choy
Fix following checks: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); CHECK: spaces preferred around that '+' (ctx:VxV) + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); ^

[PATCH] bcm2048: Fix checkpatch checks

2017-02-17 Thread Man Choy
Fix following checks: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); CHECK: spaces preferred around that '+' (ctx:VxV) + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); ^