Re: [PATCH] befs: fix return value check in befs_iget()

2013-10-30 Thread Dan Carpenter
On Wed, Oct 30, 2013 at 10:52:38AM -0700, Kees Cook wrote: > On Mon, Oct 28, 2013 at 7:00 PM, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function iget_locked() returns NULL pointer > > not ERR_PTR(). The IS_ERR() test in the return value check should > > be replaced wi

Re: [PATCH] befs: fix return value check in befs_iget()

2013-10-30 Thread Kees Cook
On Mon, Oct 28, 2013 at 7:00 PM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function iget_locked() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun Good catch, thanks! Ack

Re: [PATCH] befs: fix return value check in befs_iget()

2013-10-29 Thread Serge E. Hallyn
Quoting Wei Yongjun (weiyj...@gmail.com): > From: Wei Yongjun > > In case of error, the function iget_locked() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun Acked-by: Serge Hallyn > --- >

[PATCH] befs: fix return value check in befs_iget()

2013-10-28 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function iget_locked() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- fs/befs/linuxvfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --