RE: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-12-24 Thread Vijay Mohan Guvva
-scsi-ow...@vger.kernel.org] On Behalf Of Jim Meyering Sent: Sunday, October 14, 2012 1:51 PM To: Krishna Gudipati Cc: Andi Kleen; linux-kernel@vger.kernel.org; James E.J. Bottomley; linux-s...@vger.kernel.org Subject: Re: [PATCH] bfa: avoid buffer overrun for 12-byte model name Jim Meyering wrote

Re: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-10-14 Thread Jim Meyering
gt;>> Cc: Jim Meyering; Jing Huang; Krishna Gudipati; James E.J. Bottomley; >>>> linux- >>>> s...@vger.kernel.org >>>> Subject: [PATCH] bfa: avoid buffer overrun for 12-byte model name >>>> >>>> From: Jim Meyering

Re: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-10-14 Thread Jim Meyering
hna Gudipati; James E.J. Bottomley; linux- >>> s...@vger.kernel.org >>> Subject: [PATCH] bfa: avoid buffer overrun for 12-byte model name >>> >>> From: Jim Meyering >>> >>> we use strncpy to copy a model name of length up to 15 (16, if you count

Re: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-08-20 Thread Jim Meyering
> s...@vger.kernel.org >> Subject: [PATCH] bfa: avoid buffer overrun for 12-byte model name >> >> From: Jim Meyering >> >> we use strncpy to copy a model name of length up to 15 (16, if you count the >> NUL), into a buffer of size 12 (BFA_FCS_PORT_SYMBNAME_MODEL

RE: [PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-08-20 Thread Krishna Gudipati
> -Original Message- > From: Jim Meyering [mailto:j...@meyering.net] > Sent: Monday, August 20, 2012 9:55 AM > To: linux-kernel@vger.kernel.org > Cc: Jim Meyering; Jing Huang; Krishna Gudipati; James E.J. Bottomley; linux- > s...@vger.kernel.org > Subject: [PATCH] bfa:

[PATCH] bfa: avoid buffer overrun for 12-byte model name

2012-08-20 Thread Jim Meyering
From: Jim Meyering we use strncpy to copy a model name of length up to 15 (16, if you count the NUL), into a buffer of size 12 (BFA_FCS_PORT_SYMBNAME_MODEL_SZ). However, strncpy does not always NUL-terminate, so whenever the original model string has strlen >= 12, the following strncat reads beyo