Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-07 Thread Jack Wang
On 07.03.2017 16:46, Pavel Machek wrote: > On Mon 2017-03-06 10:43:59, Jack Wang wrote: >> >> >> On 06.03.2017 05:40, NeilBrown wrote: >>> On Fri, Mar 03 2017, Jack Wang wrote: Thanks Neil for pushing the fix. We can optimize generic_make_request a little bit: - assign bi

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-07 Thread Jens Axboe
On 03/07/2017 08:46 AM, Pavel Machek wrote: > On Mon 2017-03-06 10:43:59, Jack Wang wrote: >> >> >> On 06.03.2017 05:40, NeilBrown wrote: >>> On Fri, Mar 03 2017, Jack Wang wrote: Thanks Neil for pushing the fix. We can optimize generic_make_request a little bit: - assign b

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-07 Thread Pavel Machek
On Mon 2017-03-06 10:43:59, Jack Wang wrote: > > > On 06.03.2017 05:40, NeilBrown wrote: > > On Fri, Mar 03 2017, Jack Wang wrote: > >> > >> Thanks Neil for pushing the fix. > >> > >> We can optimize generic_make_request a little bit: > >> - assign bio_list struct hold directly instead init and m

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-07 Thread Jack Wang
On 06.03.2017 21:18, Jens Axboe wrote: > On 03/05/2017 09:40 PM, NeilBrown wrote: >> On Fri, Mar 03 2017, Jack Wang wrote: >>> >>> Thanks Neil for pushing the fix. >>> >>> We can optimize generic_make_request a little bit: >>> - assign bio_list struct hold directly instead init and merge >>> - re

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-06 Thread Jens Axboe
On 03/05/2017 09:40 PM, NeilBrown wrote: > On Fri, Mar 03 2017, Jack Wang wrote: >> >> Thanks Neil for pushing the fix. >> >> We can optimize generic_make_request a little bit: >> - assign bio_list struct hold directly instead init and merge >> - remove duplicate code >> >> I think better to squash

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-06 Thread Jack Wang
On 06.03.2017 05:40, NeilBrown wrote: > On Fri, Mar 03 2017, Jack Wang wrote: >> >> Thanks Neil for pushing the fix. >> >> We can optimize generic_make_request a little bit: >> - assign bio_list struct hold directly instead init and merge >> - remove duplicate code >> >> I think better to squash

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-05 Thread NeilBrown
On Fri, Mar 03 2017, Jack Wang wrote: > > Thanks Neil for pushing the fix. > > We can optimize generic_make_request a little bit: > - assign bio_list struct hold directly instead init and merge > - remove duplicate code > > I think better to squash into your fix. Hi Jack, I don't object to your c

Re: [PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-03 Thread Jack Wang
On 03.03.2017 06:14, NeilBrown wrote: > > [ Hi Jens, > you might have seen assorted email threads recently about > deadlocks, particular in dm-snap or md/raid1/10. Also about > the excess of rescuer threads. > I think a big part of the problem is my ancient improvement > to generic_ma

[PATCH] blk: improve order of bio handling in generic_make_request()

2017-03-02 Thread NeilBrown
[ Hi Jens, you might have seen assorted email threads recently about deadlocks, particular in dm-snap or md/raid1/10. Also about the excess of rescuer threads. I think a big part of the problem is my ancient improvement to generic_make_request to queue bios and handle them in a strict