Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-02 Thread Jens Axboe
On 6/1/20 6:38 AM, yu kuai wrote: > commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a > kree() for 'buf' if bio_integrity_add_page() return '0'. However, the > object will be freed in bio_integrity_free() since 'bio->bi_opf' and > 'bio->bi_integrity' was set previousy in

Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-02 Thread Martin K. Petersen
Hi Yu! I suggest a few minor wording tweaks to the commit message: > commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add s/add/added/ > a kree() for 'buf' if bio_integrity_add_page() return '0'. However, > the s/kree/kfree/ s/return/returns/ > object will be freed in

Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-02 Thread Bob Liu
On 6/1/20 8:38 PM, yu kuai wrote: > commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a > kree() for 'buf' if bio_integrity_add_page() return '0'. However, the > object will be freed in bio_integrity_free() since 'bio->bi_opf' and > 'bio->bi_integrity' was set previousy in

Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-02 Thread Ming Lei
On Mon, Jun 01, 2020 at 08:38:56PM +0800, yu kuai wrote: > commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a > kree() for 'buf' if bio_integrity_add_page() return '0'. However, the > object will be freed in bio_integrity_free() since 'bio->bi_opf' and > 'bio->bi_integrity'

[PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-01 Thread yu kuai
commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a kree() for 'buf' if bio_integrity_add_page() return '0'. However, the object will be freed in bio_integrity_free() since 'bio->bi_opf' and 'bio->bi_integrity' was set previousy in bio_integrity_alloc(). Fixes: commit