Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 3:07 PM, Jens Axboe wrote: > Yes, it's not impossible, I just usually prefer not to. For this case, I > just setup a for-4.15/timer, that is the current block branch with -rc3 > pulled in. I applied the two patches for floppy and amiflop, I'm > assuming Kees will respin the

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 03:53 PM, Thomas Gleixner wrote: > Jens, > > On Thu, 5 Oct 2017, Jens Axboe wrote: >> On 10/05/2017 01:23 PM, Thomas Gleixner wrote: >>> Come on. You know very well that a prerequisite for global changes which is >>> not yet used in Linus tree can get merged post merge windew in orde

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Thomas Gleixner
Jens, On Thu, 5 Oct 2017, Jens Axboe wrote: > On 10/05/2017 01:23 PM, Thomas Gleixner wrote: > > Come on. You know very well that a prerequisite for global changes which is > > not yet used in Linus tree can get merged post merge windew in order to > > avoid massive inter maintainer tree dependenc

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 01:41 PM, Jens Axboe wrote: > On 10/05/2017 01:23 PM, Thomas Gleixner wrote: >> On Thu, 5 Oct 2017, Jens Axboe wrote: >>> On 10/05/2017 11:49 AM, Kees Cook wrote: Yes, totally true. tglx and I ended up meeting face-to-face at the Kernel Recipes conference and we solved some

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 01:23 PM, Thomas Gleixner wrote: > On Thu, 5 Oct 2017, Jens Axboe wrote: >> On 10/05/2017 11:49 AM, Kees Cook wrote: >>> Yes, totally true. tglx and I ended up meeting face-to-face at the >>> Kernel Recipes conference and we solved some outstanding design issues >>> with the conversio

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Thomas Gleixner
On Thu, 5 Oct 2017, Jens Axboe wrote: > On 10/05/2017 11:49 AM, Kees Cook wrote: > > Yes, totally true. tglx and I ended up meeting face-to-face at the > > Kernel Recipes conference and we solved some outstanding design issues > > with the conversion. The timing meant the new API went into -rc3, >

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 12:49 PM, Kees Cook wrote: > On Thu, Oct 5, 2017 at 11:26 AM, Jens Axboe wrote: >> Honestly, I think the change should have waited for 4.15 in that case. >> Why the rush? It wasn't ready for the merge window. > > My understanding from my discussion with tglx was that if the API > ch

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 11:26 AM, Jens Axboe wrote: > Honestly, I think the change should have waited for 4.15 in that case. > Why the rush? It wasn't ready for the merge window. My understanding from my discussion with tglx was that if the API change waiting for 4.15, then the conversions would h

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 11:49 AM, Kees Cook wrote: > On Thu, Oct 5, 2017 at 7:56 AM, Jens Axboe wrote: >> On 10/04/2017 06:49 PM, Kees Cook wrote: >>> In preparation for unconditionally passing the struct timer_list pointer to >>> all timer callbacks, switch to using the new timer_setup() and from_timer() >

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 7:56 AM, Jens Axboe wrote: > On 10/04/2017 06:49 PM, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer explicitly. >> >>

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/04/2017 06:49 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Jens Axboe > Cc: Michal Hocko > Cc: Andrew Morton

[PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jens Axboe Cc: Michal Hocko Cc: Andrew Morton Cc: Jan Kara Cc: Johannes Weiner Cc: Nicholas Piggin