Re: [PATCH] block/umem: convert tasklet to threaded irq

2021-03-23 Thread Davidlohr Bueso
On Tue, 23 Mar 2021, Jens Axboe wrote: Me too, I'd be surprised if anyone has used it in... forever. We can probably drop it - I really dislike making core changes to something that can't even be tested. Davidlohr, assuming you had no way of testing this change? No, no way of testing these

Re: [PATCH] block/umem: convert tasklet to threaded irq

2021-03-23 Thread Jens Axboe
On 3/23/21 11:24 AM, Christoph Hellwig wrote: > On Mon, Mar 22, 2021 at 05:48:56PM -0700, Davidlohr Bueso wrote: >> Tasklets have long been deprecated as being too heavy on the system >> by running in irq context - and this is not a performance critical >> path. If a higher priority process wants

Re: [PATCH] block/umem: convert tasklet to threaded irq

2021-03-23 Thread Christoph Hellwig
On Mon, Mar 22, 2021 at 05:48:56PM -0700, Davidlohr Bueso wrote: > Tasklets have long been deprecated as being too heavy on the system > by running in irq context - and this is not a performance critical > path. If a higher priority process wants to run, it must wait for > the tasklet to finish

[PATCH] block/umem: convert tasklet to threaded irq

2021-03-22 Thread Davidlohr Bueso
Tasklets have long been deprecated as being too heavy on the system by running in irq context - and this is not a performance critical path. If a higher priority process wants to run, it must wait for the tasklet to finish before doing so. A more suitable equivalent is to converted to threaded irq