Re: [PATCH] block: Fix an error handling in add_partition

2021-01-24 Thread Jens Axboe
On 1/17/21 1:50 AM, Dinghao Liu wrote: > Once we have called device_initialize(), we should use put_device() to > give up the reference on error, just like what we have done on failure > of device_add(). Applied for 5.11, thanks. -- Jens Axboe

Re: [PATCH] block: Fix an error handling in add_partition

2021-01-20 Thread Christoph Hellwig
On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote: > Once we have called device_initialize(), we should use put_device() to > give up the reference on error, just like what we have done on failure > of device_add(). > > Signed-off-by: Dinghao Liu Looks good, Reviewed-by: Christoph Hel

[PATCH] block: Fix an error handling in add_partition

2021-01-17 Thread Dinghao Liu
Once we have called device_initialize(), we should use put_device() to give up the reference on error, just like what we have done on failure of device_add(). Signed-off-by: Dinghao Liu --- Changelog: v2: - Refine commit message. --- block/partitions/core.c | 2 +- 1 file changed, 1 insertion(

Re: Re: [PATCH] block: Fix an error handling in add_partition

2021-01-16 Thread dinghao . liu
> On 1/15/21 11:34 PM, Dinghao Liu wrote: > > Once we have called device_initialize(), we should > > use put_device() to give up the reference on error, > > just like what we have done on failure of device_add(). > > > > Signed-off-by: Dinghao Liu > Please consider having following commit message,

Re: [PATCH] block: Fix an error handling in add_partition

2021-01-16 Thread Chaitanya Kulkarni
On 1/15/21 11:34 PM, Dinghao Liu wrote: > Once we have called device_initialize(), we should > use put_device() to give up the reference on error, > just like what we have done on failure of device_add(). > > Signed-off-by: Dinghao Liu Please consider having following commit message, since above c

[PATCH] block: Fix an error handling in add_partition

2021-01-15 Thread Dinghao Liu
Once we have called device_initialize(), we should use put_device() to give up the reference on error, just like what we have done on failure of device_add(). Signed-off-by: Dinghao Liu --- block/partitions/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/partitio