Re: [PATCH] block: Refine blk_abort_request() documentation

2015-05-11 Thread Jens Axboe
On 05/11/2015 07:44 AM, Christoph Hellwig wrote: On Mon, May 11, 2015 at 01:20:00PM +0200, Bart Van Assche wrote: Document when it is safe to call this function for blk-mq queues. Maybe we should move the queue_lock acquisition into blk_abort_request for the !blk-mq case? libata and libsas al

[PATCH] block: Refine blk_abort_request() documentation

2015-05-11 Thread Bart Van Assche
Document when it is safe to call this function for blk-mq queues. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Shaohua Li --- block/blk-timeout.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/blk-timeout.c b/block/blk-timeout.c index 246dfb1..d162

Re: [PATCH] block: Refine blk_abort_request() documentation

2015-05-11 Thread Christoph Hellwig
On Mon, May 11, 2015 at 01:20:00PM +0200, Bart Van Assche wrote: > Document when it is safe to call this function for blk-mq queues. Maybe we should move the queue_lock acquisition into blk_abort_request for the !blk-mq case? libata and libsas already take it just around the call, an the usage in