Re: [PATCH] block: always requeue !fs requests at the front

2007-06-17 Thread Tejun Heo
Jens Axboe wrote: >> I'd much much prefer having a description of the problem in the actual >> comment then a hyperlink. There's just too much chance of the latter >> breaking over time, and it's impossible to update it when things change >> that should be reflected in the comment. > > The actual

Re: [PATCH] block: always requeue !fs requests at the front

2007-06-17 Thread Jens Axboe
On Sat, Jun 16 2007, Christoph Hellwig wrote: > On Fri, Jun 15, 2007 at 01:05:44PM +0200, Jens Axboe wrote: > > On Fri, Jun 15 2007, Tejun Heo wrote: > > > SCSI marks internal commands with REQ_PREEMPT and push it at the front > > > of the request queue using blk_execute_rq(). When entering suspen

Re: [PATCH] block: always requeue !fs requests at the front

2007-06-16 Thread Christoph Hellwig
On Fri, Jun 15, 2007 at 01:05:44PM +0200, Jens Axboe wrote: > On Fri, Jun 15 2007, Tejun Heo wrote: > > SCSI marks internal commands with REQ_PREEMPT and push it at the front > > of the request queue using blk_execute_rq(). When entering suspended > > or frozen state, SCSI devices are quiesced usi

Re: [PATCH] block: always requeue !fs requests at the front

2007-06-15 Thread Jeff Garzik
Tejun Heo wrote: SCSI marks internal commands with REQ_PREEMPT and push it at the front of the request queue using blk_execute_rq(). When entering suspended or frozen state, SCSI devices are quiesced using scsi_device_quiesce(). In quiesced state, only REQ_PREEMPT requests are processed. This

Re: [PATCH] block: always requeue !fs requests at the front

2007-06-15 Thread David Greaves
David, please test this. Jens, does it look okay? Phew! Works for me. I applied it to 2.6.22-rc4 (along with sata_promise_use_TF_interface_for_polling_NODATA_commands.patch) hibernate and resume worked. Thanks for digging it out Tejun (and everyone else!) :) David - To unsubscribe from t

Re: [PATCH] block: always requeue !fs requests at the front

2007-06-15 Thread Jens Axboe
On Fri, Jun 15 2007, Tejun Heo wrote: > SCSI marks internal commands with REQ_PREEMPT and push it at the front > of the request queue using blk_execute_rq(). When entering suspended > or frozen state, SCSI devices are quiesced using > scsi_device_quiesce(). In quiesced state, only REQ_PREEMPT req

[PATCH] block: always requeue !fs requests at the front

2007-06-15 Thread Tejun Heo
SCSI marks internal commands with REQ_PREEMPT and push it at the front of the request queue using blk_execute_rq(). When entering suspended or frozen state, SCSI devices are quiesced using scsi_device_quiesce(). In quiesced state, only REQ_PREEMPT requests are processed. This is how SCSI blocks

Re: [PATCH] block: always requeue !fs requests at the front

2007-06-15 Thread Jens Axboe
On Fri, Jun 15 2007, Tejun Heo wrote: > SCSI marks internal commands with REQ_PREEMPT and push it at the front > of the request queue using blk_execute_rq(). When entering suspended > or frozen state, SCSI devices are quiesced using > scsi_device_quiesce(). In quiesced state, only REQ_PREEMPT req

[PATCH] block: always requeue !fs requests at the front

2007-06-15 Thread Tejun Heo
SCSI marks internal commands with REQ_PREEMPT and push it at the front of the request queue using blk_execute_rq(). When entering suspended or frozen state, SCSI devices are quiesced using scsi_device_quiesce(). In quiesced state, only REQ_PREEMPT requests are processed. This is how SCSI blocks