Re: [PATCH] block: fix error handling in sg_io

2014-08-26 Thread Christoph Hellwig
On Tue, Aug 26, 2014 at 04:14:02PM +0200, Sabrina Dubroca wrote: > Before commit 2cada584b200 ("block: cleanup error handling in sg_io"), > we had ret = 0 before entering the last big if block of sg_io. > > Since 2cada584b200, ret = -EFAULT, which breaks hdparm: > > /dev/sda: > setting Advanced

Re: [PATCH] block: fix error handling in sg_io

2014-08-26 Thread Jens Axboe
On 08/26/2014 08:14 AM, Sabrina Dubroca wrote: > Before commit 2cada584b200 ("block: cleanup error handling in sg_io"), > we had ret = 0 before entering the last big if block of sg_io. > > Since 2cada584b200, ret = -EFAULT, which breaks hdparm: > > /dev/sda: > setting Advanced Power Management

[PATCH] block: fix error handling in sg_io

2014-08-26 Thread Sabrina Dubroca
Before commit 2cada584b200 ("block: cleanup error handling in sg_io"), we had ret = 0 before entering the last big if block of sg_io. Since 2cada584b200, ret = -EFAULT, which breaks hdparm: /dev/sda: setting Advanced Power Management level to 0xc8 (200) HDIO_DRIVE_CMD failed: Bad address

[PATCH] block: fix error handling in sg_io

2014-08-26 Thread Sabrina Dubroca
Before commit 2cada584b200 (block: cleanup error handling in sg_io), we had ret = 0 before entering the last big if block of sg_io. Since 2cada584b200, ret = -EFAULT, which breaks hdparm: /dev/sda: setting Advanced Power Management level to 0xc8 (200) HDIO_DRIVE_CMD failed: Bad address

Re: [PATCH] block: fix error handling in sg_io

2014-08-26 Thread Jens Axboe
On 08/26/2014 08:14 AM, Sabrina Dubroca wrote: Before commit 2cada584b200 (block: cleanup error handling in sg_io), we had ret = 0 before entering the last big if block of sg_io. Since 2cada584b200, ret = -EFAULT, which breaks hdparm: /dev/sda: setting Advanced Power Management level to

Re: [PATCH] block: fix error handling in sg_io

2014-08-26 Thread Christoph Hellwig
On Tue, Aug 26, 2014 at 04:14:02PM +0200, Sabrina Dubroca wrote: Before commit 2cada584b200 (block: cleanup error handling in sg_io), we had ret = 0 before entering the last big if block of sg_io. Since 2cada584b200, ret = -EFAULT, which breaks hdparm: /dev/sda: setting Advanced Power