Re: [PATCH] block: fix mq request allocation

2013-12-02 Thread Ming Lei
Hi Jeff, On Mon, Dec 2, 2013 at 11:20 PM, Jeff Moyer wrote: > Ming Lei writes: > >> blk_mq_alloc_request_pinned() may return NULL request in case of >> !__GFP_WAIT, so cause its callers to derefence NULL pointer for >> releasing current context. >> >> This patch introduces two flags to address t

Re: [PATCH] block: fix mq request allocation

2013-12-02 Thread Jeff Moyer
Jens Axboe writes: > On 12/02/2013 08:20 AM, Jeff Moyer wrote: >> Ming Lei writes: >> >>> blk_mq_alloc_request_pinned() may return NULL request in case of >>> !__GFP_WAIT, so cause its callers to derefence NULL pointer for >>> releasing current context. >>> >>> This patch introduces two flags t

Re: [PATCH] block: fix mq request allocation

2013-12-02 Thread Jens Axboe
On 12/02/2013 08:20 AM, Jeff Moyer wrote: > Ming Lei writes: > >> blk_mq_alloc_request_pinned() may return NULL request in case of >> !__GFP_WAIT, so cause its callers to derefence NULL pointer for >> releasing current context. >> >> This patch introduces two flags to address the issue. > > Hi,

Re: [PATCH] block: fix mq request allocation

2013-12-02 Thread Jeff Moyer
Ming Lei writes: > blk_mq_alloc_request_pinned() may return NULL request in case of > !__GFP_WAIT, so cause its callers to derefence NULL pointer for > releasing current context. > > This patch introduces two flags to address the issue. Hi, Ming, Good catch, but your patch seems overly complic

[PATCH] block: fix mq request allocation

2013-12-01 Thread Ming Lei
blk_mq_alloc_request_pinned() may return NULL request in case of !__GFP_WAIT, so cause its callers to derefence NULL pointer for releasing current context. This patch introduces two flags to address the issue. Cc: Jens Axboe Signed-off-by: Ming Lei --- block/blk-mq.c | 27 ---