Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-07 Thread Ming Lei
On Fri, Apr 8, 2016 at 7:29 AM, Eric Wheeler wrote: > On Thu, 7 Apr 2016, Ming Lei wrote: > >> On Thu, Apr 7, 2016 at 9:56 AM, Eric Wheeler >> wrote: >> > On Thu, 7 Apr 2016, Ming Lei wrote: >> > >> >> On Thu, Apr 7, 2016 at 9:36 AM, Eric

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-07 Thread Ming Lei
On Fri, Apr 8, 2016 at 7:29 AM, Eric Wheeler wrote: > On Thu, 7 Apr 2016, Ming Lei wrote: > >> On Thu, Apr 7, 2016 at 9:56 AM, Eric Wheeler >> wrote: >> > On Thu, 7 Apr 2016, Ming Lei wrote: >> > >> >> On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler >> >> wrote: >> >> > On Wed, 6 Apr 2016, Ming

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-07 Thread Eric Wheeler
On Thu, 7 Apr 2016, Ming Lei wrote: > On Thu, Apr 7, 2016 at 9:56 AM, Eric Wheeler > wrote: > > On Thu, 7 Apr 2016, Ming Lei wrote: > > > >> On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler > >> wrote: > >> > On Wed, 6 Apr 2016, Ming Lei

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-07 Thread Eric Wheeler
On Thu, 7 Apr 2016, Ming Lei wrote: > On Thu, Apr 7, 2016 at 9:56 AM, Eric Wheeler > wrote: > > On Thu, 7 Apr 2016, Ming Lei wrote: > > > >> On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler > >> wrote: > >> > On Wed, 6 Apr 2016, Ming Lei wrote: > >> > > >> >> After arbitrary bio size is

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Ming Lei
On Thu, Apr 7, 2016 at 9:56 AM, Eric Wheeler wrote: > On Thu, 7 Apr 2016, Ming Lei wrote: > >> On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler >> wrote: >> > On Wed, 6 Apr 2016, Ming Lei wrote: >> > >> >> After arbitrary bio size is supported,

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Ming Lei
On Thu, Apr 7, 2016 at 9:56 AM, Eric Wheeler wrote: > On Thu, 7 Apr 2016, Ming Lei wrote: > >> On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler >> wrote: >> > On Wed, 6 Apr 2016, Ming Lei wrote: >> > >> >> After arbitrary bio size is supported, the incoming bio may >> >> be very big. We have to

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Thu, 7 Apr 2016, Ming Lei wrote: > On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler > wrote: > > On Wed, 6 Apr 2016, Ming Lei wrote: > > > >> After arbitrary bio size is supported, the incoming bio may > >> be very big. We have to split the bio into small bios so that

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Thu, 7 Apr 2016, Ming Lei wrote: > On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler > wrote: > > On Wed, 6 Apr 2016, Ming Lei wrote: > > > >> After arbitrary bio size is supported, the incoming bio may > >> be very big. We have to split the bio into small bios so that > >> each holds at most

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Ming Lei
On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler wrote: > On Wed, 6 Apr 2016, Ming Lei wrote: > >> After arbitrary bio size is supported, the incoming bio may >> be very big. We have to split the bio into small bios so that >> each holds at most BIO_MAX_PAGES bvecs for

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Ming Lei
On Thu, Apr 7, 2016 at 9:36 AM, Eric Wheeler wrote: > On Wed, 6 Apr 2016, Ming Lei wrote: > >> After arbitrary bio size is supported, the incoming bio may >> be very big. We have to split the bio into small bios so that >> each holds at most BIO_MAX_PAGES bvecs for safety reason, such >> as

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Wed, 6 Apr 2016, Ming Lei wrote: > On Wed, Apr 6, 2016 at 1:44 AM, Ming Lei wrote: > > After arbitrary bio size is supported, the incoming bio may > > be very big. We have to split the bio into small bios so that > > each holds at most BIO_MAX_PAGES bvecs for safety

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Wed, 6 Apr 2016, Ming Lei wrote: > On Wed, Apr 6, 2016 at 1:44 AM, Ming Lei wrote: > > After arbitrary bio size is supported, the incoming bio may > > be very big. We have to split the bio into small bios so that > > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > > as

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Wed, 6 Apr 2016, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the following kernel crash: >

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Wed, 6 Apr 2016, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the following kernel crash: >

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 10:51:40AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 10:40 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 10:37:05AM +0800, Ming Lei wrote: > >> On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet > >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 10:51:40AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 10:40 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 10:37:05AM +0800, Ming Lei wrote: > >> On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet > >> wrote: > >> > On Wed, Apr 06, 2016 at 10:30:22AM +0800,

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 10:40 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 10:37:05AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote:

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 10:40 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 10:37:05AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: >> >> Now limit.max_segments is for limiting segments

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 10:37:05AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: > >> Now limit.max_segments is for limiting segments from hw view, one this > >> segment

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 10:37:05AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: > >> Now limit.max_segments is for limiting segments from hw view, one this > >> segment may include lots of

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: >> Now limit.max_segments is for limiting segments from hw view, one this >> segment may include lots of pages/bvecs. >> >> The current bio_clone() issue

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 10:34 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: >> Now limit.max_segments is for limiting segments from hw view, one this >> segment may include lots of pages/bvecs. >> >> The current bio_clone() issue is that we can't clone from

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: > Now limit.max_segments is for limiting segments from hw view, one this > segment may include lots of pages/bvecs. > > The current bio_clone() issue is that we can't clone from one bio which > includes more than 256 bvecs, maybe all these

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: > Now limit.max_segments is for limiting segments from hw view, one this > segment may include lots of pages/bvecs. > > The current bio_clone() issue is that we can't clone from one bio which > includes more than 256 bvecs, maybe all these

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 10:22 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 09:51:02AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 9:28 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 10:22 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 09:51:02AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 9:28 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: >> >> On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 09:51:02AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 9:28 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: > >> On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet > >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 09:51:02AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 9:28 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: > >> On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet > >> wrote: > >> > On Wed, Apr 06, 2016 at 08:59:31AM +0800,

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 9:28 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 9:28 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: >> >> On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: > >> On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet > >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 09:20:59AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: > >> On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet > >> wrote: > >> > On Wed, Apr 06, 2016 at 01:44:06AM +0800,

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 9:10 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet >> wrote: >> > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> >> After arbitrary bio size is supported, the incoming

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 9:04 AM, Shaohua Li wrote: > On Wed, Apr 06, 2016 at 08:47:56AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 2:27 AM, Shaohua Li wrote: >> > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> >> After arbitrary bio size is supported,

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 9:04 AM, Shaohua Li wrote: > On Wed, Apr 06, 2016 at 08:47:56AM +0800, Ming Lei wrote: >> On Wed, Apr 6, 2016 at 2:27 AM, Shaohua Li wrote: >> > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> >> After arbitrary bio size is supported, the incoming bio may >>

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > >> After arbitrary bio size is supported, the incoming bio may > >> be very big. We have

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet > wrote: > > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > >> After arbitrary bio size is supported, the incoming bio may > >> be very big. We have to split the bio into small

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 8:59 AM, Shaohua Li wrote: > On Tue, Apr 05, 2016 at 04:45:55PM -0800, Kent Overstreet wrote: >> On Tue, Apr 05, 2016 at 05:41:47PM -0700, Shaohua Li wrote: >> > On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: >> > > On Tue, Apr 05, 2016 at

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 8:59 AM, Shaohua Li wrote: > On Tue, Apr 05, 2016 at 04:45:55PM -0800, Kent Overstreet wrote: >> On Tue, Apr 05, 2016 at 05:41:47PM -0700, Shaohua Li wrote: >> > On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: >> > > On Tue, Apr 05, 2016 at 05:30:07PM

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Wed, Apr 06, 2016 at 08:47:56AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 2:27 AM, Shaohua Li wrote: > > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > >> After arbitrary bio size is supported, the incoming bio may > >> be very big. We have to split the bio into

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Wed, Apr 06, 2016 at 08:47:56AM +0800, Ming Lei wrote: > On Wed, Apr 6, 2016 at 2:27 AM, Shaohua Li wrote: > > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > >> After arbitrary bio size is supported, the incoming bio may > >> be very big. We have to split the bio into small bios

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 1:44 AM, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 1:44 AM, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the following

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Tue, Apr 05, 2016 at 04:45:55PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 05:41:47PM -0700, Shaohua Li wrote: > > On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > > > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > > > this one: > > > >

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Tue, Apr 05, 2016 at 04:45:55PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 05:41:47PM -0700, Shaohua Li wrote: > > On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > > > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > > > this one: > > > >

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> After arbitrary bio size is supported, the incoming bio may >> be very big. We have to split the bio into small bios so that >> each holds at most

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet wrote: > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> After arbitrary bio size is supported, the incoming bio may >> be very big. We have to split the bio into small bios so that >> each holds at most BIO_MAX_PAGES bvecs for safety

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 2:27 AM, Shaohua Li wrote: > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> After arbitrary bio size is supported, the incoming bio may >> be very big. We have to split the bio into small bios so that >> each holds at most BIO_MAX_PAGES bvecs for

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
On Wed, Apr 6, 2016 at 2:27 AM, Shaohua Li wrote: > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: >> After arbitrary bio size is supported, the incoming bio may >> be very big. We have to split the bio into small bios so that >> each holds at most BIO_MAX_PAGES bvecs for safety

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Tue, Apr 05, 2016 at 05:41:47PM -0700, Shaohua Li wrote: > On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > > this one: > > > http://marc.info/?l=linux-kernel=145926976808760=2 > > > > Ah. that patch won't

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Tue, Apr 05, 2016 at 05:41:47PM -0700, Shaohua Li wrote: > On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > > this one: > > > http://marc.info/?l=linux-kernel=145926976808760=2 > > > > Ah. that patch won't

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > this one: > > http://marc.info/?l=linux-kernel=145926976808760=2 > > Ah. that patch won't actually fix the bug, since md isn't using > blk_default_limits, it's using

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > this one: > > http://marc.info/?l=linux-kernel=145926976808760=2 > > Ah. that patch won't actually fix the bug, since md isn't using > blk_default_limits, it's using

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > this one: > http://marc.info/?l=linux-kernel=145926976808760=2 Ah. that patch won't actually fix the bug, since md isn't using blk_default_limits, it's using blk_set_stacking_limits().

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > this one: > http://marc.info/?l=linux-kernel=145926976808760=2 Ah. that patch won't actually fix the bug, since md isn't using blk_default_limits, it's using blk_set_stacking_limits().

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Tue, Apr 05, 2016 at 04:27:33PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 11:27:21AM -0700, Shaohua Li wrote: > > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > > > After arbitrary bio size is supported, the incoming bio may > > > be very big. We have to split the bio

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Tue, Apr 05, 2016 at 04:27:33PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 11:27:21AM -0700, Shaohua Li wrote: > > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > > > After arbitrary bio size is supported, the incoming bio may > > > be very big. We have to split the bio

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Tue, Apr 05, 2016 at 11:27:21AM -0700, Shaohua Li wrote: > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > > After arbitrary bio size is supported, the incoming bio may > > be very big. We have to split the bio into small bios so that > > each holds at most BIO_MAX_PAGES bvecs for

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Kent Overstreet
On Tue, Apr 05, 2016 at 11:27:21AM -0700, Shaohua Li wrote: > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > > After arbitrary bio size is supported, the incoming bio may > > be very big. We have to split the bio into small bios so that > > each holds at most BIO_MAX_PAGES bvecs for

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Shaohua Li
On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the

[PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
After arbitrary bio size is supported, the incoming bio may be very big. We have to split the bio into small bios so that each holds at most BIO_MAX_PAGES bvecs for safety reason, such as bio_clone(). This patch fixes the following kernel crash: > [ 172.660142] BUG: unable to handle kernel NULL

[PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-05 Thread Ming Lei
After arbitrary bio size is supported, the incoming bio may be very big. We have to split the bio into small bios so that each holds at most BIO_MAX_PAGES bvecs for safety reason, such as bio_clone(). This patch fixes the following kernel crash: > [ 172.660142] BUG: unable to handle kernel NULL