Re: [PATCH] block: xen-blkback: don't get/put blkif ref for each queue

2016-09-26 Thread Konrad Rzeszutek Wilk
On Mon, Sep 26, 2016 at 03:36:24PM +0800, Bob Liu wrote: > xen_blkif_get/put() for each queue is useless, and introduces a bug: > > If there is I/O inflight when removing device, xen_blkif_disconnect() will > return -EBUSY and xen_blkif_put() not be called. > Which means the references are

Re: [PATCH] block: xen-blkback: don't get/put blkif ref for each queue

2016-09-26 Thread Konrad Rzeszutek Wilk
On Mon, Sep 26, 2016 at 03:36:24PM +0800, Bob Liu wrote: > xen_blkif_get/put() for each queue is useless, and introduces a bug: > > If there is I/O inflight when removing device, xen_blkif_disconnect() will > return -EBUSY and xen_blkif_put() not be called. > Which means the references are

[PATCH] block: xen-blkback: don't get/put blkif ref for each queue

2016-09-26 Thread Bob Liu
xen_blkif_get/put() for each queue is useless, and introduces a bug: If there is I/O inflight when removing device, xen_blkif_disconnect() will return -EBUSY and xen_blkif_put() not be called. Which means the references are leaked, then even if I/O completed, the xen_blkif_put() won't call

[PATCH] block: xen-blkback: don't get/put blkif ref for each queue

2016-09-26 Thread Bob Liu
xen_blkif_get/put() for each queue is useless, and introduces a bug: If there is I/O inflight when removing device, xen_blkif_disconnect() will return -EBUSY and xen_blkif_put() not be called. Which means the references are leaked, then even if I/O completed, the xen_blkif_put() won't call