Re: [PATCH] bnx2x: Convert return 0 to return rc

2014-05-18 Thread David Miller
From: Joe Perches Date: Thu, 15 May 2014 23:51:43 -0700 > These "return 0;" uses seem wrong as there are > rc variables where error return values are set > but unused. > > Signed-off-by: Joe Perches Applied, thanks Joe. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] bnx2x: Convert return 0 to return rc

2014-05-16 Thread David Miller
From: Joe Perches Date: Fri, 16 May 2014 13:12:24 -0700 > Couple things actually: > o Could you please update the MAINTAINER entry for > BNX2X? Ariel Elior's email address is still listed > as @broadcom and that seems to bounce. Let's please give the Broadcom folks a reasonable opportunity

Re: [PATCH] bnx2x: Convert return 0 to return rc

2014-05-16 Thread Joe Perches
v > > Cc: netdev; linux-kernel > > Subject: [PATCH] bnx2x: Convert return 0 to return rc > > > > These "return 0;" uses seem wrong as there are > > rc variables where error return values are set > > but unused. [] > Thanks Joe for catching this! >

RE: [PATCH] bnx2x: Convert return 0 to return rc

2014-05-16 Thread Dmitry Kravkov
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Friday, May 16, 2014 9:52 AM > To: Ariel Elior; Dmitry Kravkov > Cc: netdev; linux-kernel > Subject: [PATCH] bnx2x: Convert return 0 t

[PATCH] bnx2x: Convert return 0 to return rc

2014-05-15 Thread Joe Perches
These "return 0;" uses seem wrong as there are rc variables where error return values are set but unused. Signed-off-by: Joe Perches --- Hey Ariel/Dmitry I've no idea what's right here, but the current code seems wrong. (or at least under-commented) It seems Dmitry changed these, perhaps to ma