Re: [PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread Linus Lüssing
On Mon, Aug 05, 2013 at 03:42:22PM -0700, Stephen Hemminger wrote: > On Tue, 6 Aug 2013 00:32:05 +0200 > Linus Lüssing wrote: > > > Currently we are reading an uninitialized value for the max_delay > > variable when snooping an MLD query message of invalid length and would > > update our timers

Re: [PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread David Miller
From: Linus Lüssing Date: Tue, 6 Aug 2013 00:32:05 +0200 > Currently we are reading an uninitialized value for the max_delay > variable when snooping an MLD query message of invalid length and would > update our timers with that. > > Fixing this by simply ignoring such broken MLD queries (just

Re: [PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread Stephen Hemminger
On Tue, 6 Aug 2013 00:32:05 +0200 Linus Lüssing wrote: > Currently we are reading an uninitialized value for the max_delay > variable when snooping an MLD query message of invalid length and would > update our timers with that. > > Fixing this by simply ignoring such broken MLD queries (just

[PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread Linus Lüssing
Currently we are reading an uninitialized value for the max_delay variable when snooping an MLD query message of invalid length and would update our timers with that. Fixing this by simply ignoring such broken MLD queries (just like we do for IGMP already). This is a regression introduced by:

[PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread Linus Lüssing
Currently we are reading an uninitialized value for the max_delay variable when snooping an MLD query message of invalid length and would update our timers with that. Fixing this by simply ignoring such broken MLD queries (just like we do for IGMP already). This is a regression introduced by:

Re: [PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread Stephen Hemminger
On Tue, 6 Aug 2013 00:32:05 +0200 Linus Lüssing linus.luess...@web.de wrote: Currently we are reading an uninitialized value for the max_delay variable when snooping an MLD query message of invalid length and would update our timers with that. Fixing this by simply ignoring such broken MLD

Re: [PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Tue, 6 Aug 2013 00:32:05 +0200 Currently we are reading an uninitialized value for the max_delay variable when snooping an MLD query message of invalid length and would update our timers with that. Fixing this by simply ignoring such broken

Re: [PATCH] bridge: don't try to update timers in case of broken MLD queries

2013-08-05 Thread Linus Lüssing
On Mon, Aug 05, 2013 at 03:42:22PM -0700, Stephen Hemminger wrote: On Tue, 6 Aug 2013 00:32:05 +0200 Linus Lüssing linus.luess...@web.de wrote: Currently we are reading an uninitialized value for the max_delay variable when snooping an MLD query message of invalid length and would