Re: [PATCH] bsg referencing bus driver module

2018-05-01 Thread Anatoliy Glagolev
Any comments on the new patch (which, I think, addresses the concern about module being stuck in unloadable state forever; if not, there would be a leak in the bsg layer)? Or on dropping a reference to bsg_class_device's parent early before the bsg_class_device itself is gone, to implement James's

Re: [PATCH] bsg referencing bus driver module

2018-05-01 Thread Anatoliy Glagolev
Any comments on the new patch (which, I think, addresses the concern about module being stuck in unloadable state forever; if not, there would be a leak in the bsg layer)? Or on dropping a reference to bsg_class_device's parent early before the bsg_class_device itself is gone, to implement James's

Re: [PATCH] bsg referencing bus driver module

2018-04-26 Thread Anatoliy Glagolev
Any thoughts on this? Can we really drop a reference from a child device (bsg_class_device) to a parent device (Scsi_Host) while the child device is still around at fc_bsg_remove time? If not, please consider a fix with module references. I realized that the previous version of the fix had a

Re: [PATCH] bsg referencing bus driver module

2018-04-26 Thread Anatoliy Glagolev
Any thoughts on this? Can we really drop a reference from a child device (bsg_class_device) to a parent device (Scsi_Host) while the child device is still around at fc_bsg_remove time? If not, please consider a fix with module references. I realized that the previous version of the fix had a

Re: [PATCH] bsg referencing bus driver module

2018-04-23 Thread Anatoliy Glagolev
Thanks, James. The idea of cutting communications with Scsi_Host at bsg_unregister_queue(..) time and leaving bsg_class_device to its own fate makes a lot of sense, conceptually. But there are implementation issues that are difficult to work around. bsg.c creates bsg_class_device and takes a

Re: [PATCH] bsg referencing bus driver module

2018-04-23 Thread Anatoliy Glagolev
Thanks, James. The idea of cutting communications with Scsi_Host at bsg_unregister_queue(..) time and leaving bsg_class_device to its own fate makes a lot of sense, conceptually. But there are implementation issues that are difficult to work around. bsg.c creates bsg_class_device and takes a

Re: [PATCH] bsg referencing bus driver module

2018-04-22 Thread James Bottomley
On Fri, 2018-04-20 at 16:44 -0600, Anatoliy Glagolev wrote: >   > > This patch isn't applyable because your mailer has changed all the > > tabs to spaces. > > > > I also think there's no need to do it this way.  I think what we > > need is for fc_bsg_remove() to wait until the bsg queue is > >

Re: [PATCH] bsg referencing bus driver module

2018-04-22 Thread James Bottomley
On Fri, 2018-04-20 at 16:44 -0600, Anatoliy Glagolev wrote: >   > > This patch isn't applyable because your mailer has changed all the > > tabs to spaces. > > > > I also think there's no need to do it this way.  I think what we > > need is for fc_bsg_remove() to wait until the bsg queue is > >

Re: [PATCH] bsg referencing bus driver module

2018-04-20 Thread Anatoliy Glagolev
> This patch isn't applyable because your mailer has changed all the tabs > to spaces. > > I also think there's no need to do it this way. I think what we need > is for fc_bsg_remove() to wait until the bsg queue is drained. It does > look like the author thought this happened otherwise the

Re: [PATCH] bsg referencing bus driver module

2018-04-20 Thread Anatoliy Glagolev
> This patch isn't applyable because your mailer has changed all the tabs > to spaces. > > I also think there's no need to do it this way. I think what we need > is for fc_bsg_remove() to wait until the bsg queue is drained. It does > look like the author thought this happened otherwise the

Re: [PATCH] bsg referencing bus driver module

2018-04-20 Thread James Bottomley
On Thu, 2018-04-19 at 15:10 -0700, Anatoliy Glagolev wrote: > Updated: rebased on recent Linux, cc-ed maintainers per instructions > in MAINTAINERS file > > From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 > 2001 > From: Anatoliy Glagolev > Date: Thu,

Re: [PATCH] bsg referencing bus driver module

2018-04-20 Thread James Bottomley
On Thu, 2018-04-19 at 15:10 -0700, Anatoliy Glagolev wrote: > Updated: rebased on recent Linux, cc-ed maintainers per instructions > in MAINTAINERS file > > From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 > 2001 > From: Anatoliy Glagolev > Date: Thu, 19 Apr 2018 15:06:06 -0600

Re: [PATCH] bsg referencing bus driver module

2018-04-19 Thread Anatoliy Glagolev
Updated: rebased on recent Linux, cc-ed maintainers per instructions in MAINTAINERS file >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing parent module

Re: [PATCH] bsg referencing bus driver module

2018-04-19 Thread Anatoliy Glagolev
Updated: rebased on recent Linux, cc-ed maintainers per instructions in MAINTAINERS file >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing parent module Fixing a bug when bsg