Re: [PATCH] btrfs: Remove some dead code

2016-11-03 Thread Christophe JAILLET
Le 03/11/2016 à 13:43, Tobias Klauser a écrit : On 2016-11-01 at 11:26:06 +0100, Christophe JAILLET wrote: 'btrfs_iget()' can not return an error pointer, so this test can be removed. This descrption does not match what the patch actually does. Shouldn't it say "...can not return NULL, so thi

Re: [PATCH] btrfs: Remove some dead code

2016-11-03 Thread Tobias Klauser
On 2016-11-01 at 11:26:06 +0100, Christophe JAILLET wrote: > 'btrfs_iget()' can not return an error pointer, so this test can be > removed. This descrption does not match what the patch actually does. Shouldn't it say "...can not return NULL, so this test can be removed."? > Signed-off-by: Chr

Re: [PATCH] btrfs: Remove some dead code

2016-11-02 Thread David Sterba
On Tue, Nov 01, 2016 at 11:26:06AM +0100, Christophe JAILLET wrote: > 'btrfs_iget()' can not return an error pointer, so this test can be > removed. > > Signed-off-by: Christophe JAILLET Reviewed-by: David Sterba

[PATCH] btrfs: Remove some dead code

2016-11-01 Thread Christophe JAILLET
'btrfs_iget()' can not return an error pointer, so this test can be removed. Signed-off-by: Christophe JAILLET --- fs/btrfs/free-space-cache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index e4b48f377d3a..afd8b0c10acd 100644 --