Re: [PATCH] btrfs: always write superblocks synchronously

2017-05-03 Thread Chris Mason
On 05/03/2017 04:36 AM, Jan Kara wrote: On Tue 02-05-17 09:28:13, Davidlohr Bueso wrote: Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO when the

Re: [PATCH] btrfs: always write superblocks synchronously

2017-05-03 Thread Chris Mason
On 05/03/2017 04:36 AM, Jan Kara wrote: On Tue 02-05-17 09:28:13, Davidlohr Bueso wrote: Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO when the

Re: [PATCH] btrfs: always write superblocks synchronously

2017-05-03 Thread Jan Kara
On Tue 02-05-17 09:28:13, Davidlohr Bueso wrote: > Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as > synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. > Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO > when the disk doesn't have volatile write cache

Re: [PATCH] btrfs: always write superblocks synchronously

2017-05-03 Thread Jan Kara
On Tue 02-05-17 09:28:13, Davidlohr Bueso wrote: > Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as > synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. > Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO > when the disk doesn't have volatile write cache

[PATCH] btrfs: always write superblocks synchronously

2017-05-02 Thread Davidlohr Bueso
Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO when the disk doesn't have volatile write cache and thus effectively make the write async. This was seen

[PATCH] btrfs: always write superblocks synchronously

2017-05-02 Thread Davidlohr Bueso
Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO when the disk doesn't have volatile write cache and thus effectively make the write async. This was seen