Re: [PATCH] btrfs: remove the useless value assignment in block_rsv_release_bytes

2020-11-23 Thread David Sterba
On Tue, Nov 17, 2020 at 11:17:17AM +0800, kaixuxia wrote: > > > On 2020/11/16 23:15, David Sterba wrote: > > On Sun, Nov 15, 2020 at 02:39:23PM +0800, xiakaixu1...@gmail.com wrote: > >> From: Kaixu Xia > >> > >> The variable qgroup_to_release is overwritten by the following if/else > >>

Re: [PATCH] btrfs: remove the useless value assignment in block_rsv_release_bytes

2020-11-16 Thread kaixuxia
On 2020/11/16 23:15, David Sterba wrote: > On Sun, Nov 15, 2020 at 02:39:23PM +0800, xiakaixu1...@gmail.com wrote: >> From: Kaixu Xia >> >> The variable qgroup_to_release is overwritten by the following if/else >> statement before it is used, so this assignment is useless. Remove it. > >

Re: [PATCH] btrfs: remove the useless value assignment in block_rsv_release_bytes

2020-11-16 Thread David Sterba
On Sun, Nov 15, 2020 at 02:39:23PM +0800, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The variable qgroup_to_release is overwritten by the following if/else > statement before it is used, so this assignment is useless. Remove it. Again this lacks explanation why removing it is correct.

[PATCH] btrfs: remove the useless value assignment in block_rsv_release_bytes

2020-11-14 Thread xiakaixu1987
From: Kaixu Xia The variable qgroup_to_release is overwritten by the following if/else statement before it is used, so this assignment is useless. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- fs/btrfs/block-rsv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)