Re: [PATCH] btrfs: remove the useless value assignment in btrfs_defrag_file

2020-11-16 Thread kaixuxia
On 2020/11/16 23:13, David Sterba wrote: > On Sat, Nov 14, 2020 at 05:06:21PM +0800, xiakaixu1...@gmail.com wrote: >> From: Kaixu Xia >> >> The variable ret is overwritten by the following variable defrag_count >> and this assignment is useless, so remove it. > > This could be actually pointin

Re: [PATCH] btrfs: remove the useless value assignment in btrfs_defrag_file

2020-11-16 Thread David Sterba
On Sat, Nov 14, 2020 at 05:06:21PM +0800, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The variable ret is overwritten by the following variable defrag_count > and this assignment is useless, so remove it. This could be actually pointing to a bug, please explain why you think it's correct

[PATCH] btrfs: remove the useless value assignment in btrfs_defrag_file

2020-11-14 Thread xiakaixu1987
From: Kaixu Xia The variable ret is overwritten by the following variable defrag_count and this assignment is useless, so remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- fs/btrfs/ioctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c ind