Re: [KJ] Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-05 Thread Randy Dunlap
On Tue, 05 Jun 2007 18:31:42 +0200 Yoann Padioleau wrote: > Oliver Neukum <[EMAIL PROTECTED]> writes: > > > Am Dienstag, 5. Juni 2007 13:05 schrieb Yoann Padioleau: > >> Ok. Do you have a preference on the format ?  a : format  ? > >> > >> Is there a place that gathered all those implicit progra

Re: [KJ] Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-05 Thread Yoann Padioleau
Oliver Neukum <[EMAIL PROTECTED]> writes: > Am Dienstag, 5. Juni 2007 13:05 schrieb Yoann Padioleau: >> Ok. Do you have a preference on the format ?  a : format  ? >> >> Is there a place that gathered all those implicit programming rules >> (that copy_from_user must not be called inside a spinlo

Re: [KJ] Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-05 Thread Andrew Morton
On Tue, 05 Jun 2007 13:05:18 +0200 Yoann Padioleau <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > > >> > >> net/wan/lmc/lmc_main.c|2 +- > >> scsi/megaraid/megaraid_mm.c |2 +- > >> usb/serial/io_ti.c|2 +- > >> usb/serial/ti_usb_3410_

Re: [KJ] Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-05 Thread Oliver Neukum
Am Dienstag, 5. Juni 2007 13:05 schrieb Yoann Padioleau: > Ok. Do you have a preference on the format ?  a : format  ? > > Is there a place that gathered all those implicit programming rules > (that copy_from_user must not be called inside a spinlock, etc) so that > I can translate them in a scri

Re: [KJ] Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-05 Thread Yoann Padioleau
Andrew Morton <[EMAIL PROTECTED]> writes: >> >> net/wan/lmc/lmc_main.c|2 +- >> scsi/megaraid/megaraid_mm.c |2 +- >> usb/serial/io_ti.c|2 +- >> usb/serial/ti_usb_3410_5052.c |2 +- >> usb/serial/whiteheat.c|6 +++--- >> 5 files changed, 7 inser

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-05 Thread Oliver Neukum
Am Dienstag, 5. Juni 2007 06:08 schrieb Andrew Morton: > Everything in USB appears to already be fixed, apart from the io_ti.c bug. Yes, that's a bug. I've queued a patch. Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Andrew Morton
On Mon, 4 Jun 2007 21:00:18 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c > > index 544098d..9ec38e3 100644 > > --- a/drivers/usb/serial/io_ti.c > > +++ b/drivers/usb/serial/io_ti.c > > @@ -2351,7 +2351,7 @@ static int resta

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 18:25:28 +0200 Yoann Padioleau <[EMAIL PROTECTED]> wrote: > > In a few files a function such as usb_submit_urb is taking GFP_KERNEL > as an argument whereas this function call is inside a > spin_lock_irqsave region of code. Documentation says that it must be > GFP_ATOMIC inste

[PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Yoann Padioleau
In a few files a function such as usb_submit_urb is taking GFP_KERNEL as an argument whereas this function call is inside a spin_lock_irqsave region of code. Documentation says that it must be GFP_ATOMIC instead. Me and my colleagues have made a tool targeting program transformations in device dr