Each iteration of for_each_child_of_node puts the previous node, but
in the case of a break from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the break.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.li...@gmail.com>
---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
                i = nb_ace + nb_ace_lite;
 
-               if (i >= nb_cci_ports)
+               if (i >= nb_cci_ports) {
+                       of_node_put(cp);
                        break;
+               }
 
                if (of_property_read_string(cp, "interface-type",
                                        &match_str)) {
-- 
2.19.1

Reply via email to