Re: [PATCH] bus: mhi: core: fix potential operator-precedence with BHI macros

2020-11-09 Thread Manivannan Sadhasivam
On Tue, Oct 20, 2020 at 02:29:45PM -0600, Jeffrey Hugo wrote: > The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is > a BHI register index. If 'n' is an expression rather than a simple > value, there can be an operator precedence issue which can result > in the incorrect calculation

Re: [PATCH] bus: mhi: core: fix potential operator-precedence with BHI macros

2020-11-05 Thread Manivannan Sadhasivam
On Tue, Oct 20, 2020 at 02:29:45PM -0600, Jeffrey Hugo wrote: > The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is > a BHI register index. If 'n' is an expression rather than a simple > value, there can be an operator precedence issue which can result > in the incorrect calculation

Re: [PATCH] bus: mhi: core: fix potential operator-precedence with BHI macros

2020-10-21 Thread Hemant Kumar
On 10/20/20 1:29 PM, Jeffrey Hugo wrote: The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset.

[PATCH] bus: mhi: core: fix potential operator-precedence with BHI macros

2020-10-20 Thread Jeffrey Hugo
The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is a BHI register index. If 'n' is an expression rather than a simple value, there can be an operator precedence issue which can result in the incorrect calculation of the register offset. Adding parentheses around the macro parameter