Re: [PATCH] bus: qcom: Put child node before return

2021-01-23 Thread Linus Walleij
On Sat, Jan 23, 2021 at 12:19 AM Bjorn Andersson wrote: > On Fri 22 Jan 16:47 CST 2021, Linus Walleij wrote: > > > On Thu, Jan 21, 2021 at 12:49 PM Pan Bian wrote: > > > > > Put child node before return to fix potential reference count leak. > > > Generally, the reference count of child is increm

Re: [PATCH] bus: qcom: Put child node before return

2021-01-22 Thread Bjorn Andersson
On Fri 22 Jan 16:47 CST 2021, Linus Walleij wrote: > On Thu, Jan 21, 2021 at 12:49 PM Pan Bian wrote: > > > Put child node before return to fix potential reference count leak. > > Generally, the reference count of child is incremented and decremented > > automatically in the macro for_each_avail

Re: [PATCH] bus: qcom: Put child node before return

2021-01-22 Thread Linus Walleij
On Thu, Jan 21, 2021 at 12:49 PM Pan Bian wrote: > Put child node before return to fix potential reference count leak. > Generally, the reference count of child is incremented and decremented > automatically in the macro for_each_available_child_of_node() and should > be decremented manually if t

[PATCH] bus: qcom: Put child node before return

2021-01-21 Thread Pan Bian
Put child node before return to fix potential reference count leak. Generally, the reference count of child is incremented and decremented automatically in the macro for_each_available_child_of_node() and should be decremented manually if the loop is broken in loop body. Fixes: 335a12754808 ("bus: