Re: [PATCH] caif: Do not dereference NULL in chnl_recv_cb()

2012-08-20 Thread David Miller
From: Sjur BRENDELAND Date: Mon, 20 Aug 2012 08:33:35 +0200 >> In net/caif/chnl_net.c::chnl_recv_cb() we call skb_header_pointer() >> which may return NULL, but we do not check for a NULL pointer before >> dereferencing it. >> This patch adds such a NULL check and properly free's allocated memory

RE: [PATCH] caif: Do not dereference NULL in chnl_recv_cb()

2012-08-19 Thread Sjur BRENDELAND
> In net/caif/chnl_net.c::chnl_recv_cb() we call skb_header_pointer() > which may return NULL, but we do not check for a NULL pointer before > dereferencing it. > This patch adds such a NULL check and properly free's allocated memory > and return an error (-EINVAL) on failure - much better than cra

[PATCH] caif: Do not dereference NULL in chnl_recv_cb()

2012-08-17 Thread Jesper Juhl
In net/caif/chnl_net.c::chnl_recv_cb() we call skb_header_pointer() which may return NULL, but we do not check for a NULL pointer before dereferencing it. This patch adds such a NULL check and properly free's allocated memory and return an error (-EINVAL) on failure - much better than crashing.. S