On Fri, 2014-04-11 at 06:51 +0800, Xiao Jin wrote:
> Hi, Oliver,
>
> On 04/10/2014 04:02 PM, Oliver Neukum wrote:
> > On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
> >> Thanks all for the review. We meet with the problems when developing
> >> product. I would like to explain my
On Tue, Apr 08, 2014 at 12:22:22PM +0200, Oliver Neukum wrote:
> On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> > On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
> > > We find two problems on acm tty write delayed mechanism.
> >
> > Then you should split this into two patches.
[ +CC: Jiri and Peter ]
On Thu, Apr 10, 2014 at 10:02:03AM +0200, Oliver Neukum wrote:
> On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
> > Thanks all for the review. We meet with the problems when developing
> > product. I would like to explain my understanding.
> >
> > On 04/08/2014 11:05
[ +CC: Jiri and Peter ]
On Thu, Apr 10, 2014 at 10:02:03AM +0200, Oliver Neukum wrote:
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao
On Tue, Apr 08, 2014 at 12:22:22PM +0200, Oliver Neukum wrote:
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
Then you should split this into two patches.
(1)
On Fri, 2014-04-11 at 06:51 +0800, Xiao Jin wrote:
Hi, Oliver,
On 04/10/2014 04:02 PM, Oliver Neukum wrote:
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On
Hi, Oliver,
On 04/10/2014 04:02 PM, Oliver Neukum wrote:
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
> Thanks all for the review. We meet with the problems when developing
> product. I would like to explain my understanding.
>
> On 04/08/2014 11:05 AM, Xiao Jin wrote:
> >
> > We find two problems on acm tty write delayed mechanism.
> > (1) When
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm
Hi, Oliver,
On 04/10/2014 04:02 PM, Oliver Neukum wrote:
On Wed, 2014-04-09 at 22:57 +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on
On Wed, Apr 09, 2014 at 10:57:10PM +0800, Xiao Jin wrote:
> Thanks all for the review. We meet with the problems when developing
> product. I would like to explain my understanding.
>
> On 04/08/2014 11:05 AM, Xiao Jin wrote:
> >
> >We find two problems on acm tty write delayed mechanism.
> >(1)
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write
On Wed, Apr 09, 2014 at 10:57:10PM +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm
> > > If I see this correctly, then ASYNCB_INITIALIZED is cleared in
> > > tty_port_close() we is called from acm_tty_close(). Thus it should
> > > be enough to make sure that the device is resumed at the beginning
> > > of acm_tty_close() and acm_resume() will do the job automatically.
> > > What
On Tue, 2014-04-08 at 15:17 +0200, Johan Hovold wrote:
> [ +CC: Alan ]
>
> On Tue, Apr 08, 2014 at 12:33:31PM +0200, Oliver Neukum wrote:
> > On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> > > On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
> >
> > > > (2) acm tty port
[ +CC: Alan ]
On Tue, Apr 08, 2014 at 12:33:31PM +0200, Oliver Neukum wrote:
> On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> > On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
>
> > > (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
> > > close. If acm resume
[ +CC: Oliver ]
On Tue, Apr 08, 2014 at 12:22:29PM +0100, One Thousand Gnomes wrote:
> > (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
> > close. If acm resume callback run after ASYNCB_INITIALIZED flag
> > cleared, there will have no chance for delayed write to start.
> > That
> (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
> close. If acm resume callback run after ASYNCB_INITIALIZED flag
> cleared, there will have no chance for delayed write to start.
> That lead to acm_wb.use can't be cleared. If user space open
> acm tty again and try to setd, tty
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
> > (2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
> > close. If acm resume callback run after ASYNCB_INITIALIZED flag
> > cleared, there will have no chance for
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
> On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
> > We find two problems on acm tty write delayed mechanism.
>
> Then you should split this into two patches.
>
> > (1) When acm resume, the delayed wb will be started. But now
> >
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
> We find two problems on acm tty write delayed mechanism.
Then you should split this into two patches.
> (1) When acm resume, the delayed wb will be started. But now
> only one write can be saved during acm suspend. More acm write
> may
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
Then you should split this into two patches.
(1) When acm resume, the delayed wb will be started. But now
only one write can be saved during acm suspend. More acm write
may be
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
Then you should split this into two patches.
(1) When acm resume, the delayed wb will be started. But now
only one
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
(2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
close. If acm resume callback run after ASYNCB_INITIALIZED flag
cleared, there will have no chance for delayed
(2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
close. If acm resume callback run after ASYNCB_INITIALIZED flag
cleared, there will have no chance for delayed write to start.
That lead to acm_wb.use can't be cleared. If user space open
acm tty again and try to setd, tty will be
[ +CC: Oliver ]
On Tue, Apr 08, 2014 at 12:22:29PM +0100, One Thousand Gnomes wrote:
(2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
close. If acm resume callback run after ASYNCB_INITIALIZED flag
cleared, there will have no chance for delayed write to start.
That lead to
[ +CC: Alan ]
On Tue, Apr 08, 2014 at 12:33:31PM +0200, Oliver Neukum wrote:
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
(2) acm tty port ASYNCB_INITIALIZED flag will be cleared when
close. If acm resume callback run
On Tue, 2014-04-08 at 15:17 +0200, Johan Hovold wrote:
[ +CC: Alan ]
On Tue, Apr 08, 2014 at 12:33:31PM +0200, Oliver Neukum wrote:
On Tue, 2014-04-08 at 09:33 +0200, Johan Hovold wrote:
On Tue, Apr 08, 2014 at 11:05:20AM +0800, Xiao Jin wrote:
(2) acm tty port ASYNCB_INITIALIZED
If I see this correctly, then ASYNCB_INITIALIZED is cleared in
tty_port_close() we is called from acm_tty_close(). Thus it should
be enough to make sure that the device is resumed at the beginning
of acm_tty_close() and acm_resume() will do the job automatically.
What do you think?
From: xiao jin
Date: Tue, 25 Mar 2014 15:54:36 +0800
Subject: [PATCH] cdc-acm: some enhancement on acm delayed write
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write can be saved during acm suspend. More acm
From: xiao jin jin.x...@intel.com
Date: Tue, 25 Mar 2014 15:54:36 +0800
Subject: [PATCH] cdc-acm: some enhancement on acm delayed write
We find two problems on acm tty write delayed mechanism.
(1) When acm resume, the delayed wb will be started. But now
only one write can be saved during acm
32 matches
Mail list logo